Skip to content

Make verify_peer configurable and default it to false#294

Merged
ronwsmith merged 2 commits intooesmith:masterfrom
bidwrangler:master
Aug 27, 2020
Merged

Make verify_peer configurable and default it to false#294
ronwsmith merged 2 commits intooesmith:masterfrom
bidwrangler:master

Conversation

@aharbick
Copy link
Contributor

Resolves #293

Also note that this doesn't make these warnings

[WARNING; em-http-request] TLS hostname validation is disabled (use 'tls: {verify_peer: true}'), see CVE-2020-13482 and https://github.com/igrigorik/em-http-request/issues/339 for details

go away unless this is merged: igrigorik/em-http-request#341

OR verify_peer: true is used.

@ronwsmith
Copy link
Collaborator

Thanks for the contribution! Can you add this new option to the README too?

@aharbick
Copy link
Contributor Author

How about 356cbc1 @ronwsmith ?

@ronwsmith
Copy link
Collaborator

Looks good, will try to get this in soon!

@CarwynNelson
Copy link

@ronwsmith Would you be able to merge this? It would really help to reduce the noise in our logs

@ronwsmith ronwsmith merged commit 4cd4d85 into oesmith:master Aug 27, 2020
@ronwsmith
Copy link
Collaborator

@CarwynNelson thanks for the nudge, just released in 2.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

specify verify_peer option to EM::HttpRequest

3 participants