Make verify_peer configurable and default it to false#294
Merged
ronwsmith merged 2 commits intooesmith:masterfrom Aug 27, 2020
Merged
Make verify_peer configurable and default it to false#294ronwsmith merged 2 commits intooesmith:masterfrom
ronwsmith merged 2 commits intooesmith:masterfrom
Conversation
Collaborator
|
Thanks for the contribution! Can you add this new option to the README too? |
Contributor
Author
|
How about 356cbc1 @ronwsmith ? |
Collaborator
|
Looks good, will try to get this in soon! |
|
@ronwsmith Would you be able to merge this? It would really help to reduce the noise in our logs |
Collaborator
|
@CarwynNelson thanks for the nudge, just released in 2.4.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #293
Also note that this doesn't make these warnings
go away unless this is merged: igrigorik/em-http-request#341
OR
verify_peer: trueis used.