Skip to content

Python ufmt fixes#2

Merged
ofek merged 6 commits intoofek:python-packagefrom
sdwilsh:python-ufmt-fixes
Oct 30, 2025
Merged

Python ufmt fixes#2
ofek merged 6 commits intoofek:python-packagefrom
sdwilsh:python-ufmt-fixes

Conversation

@sdwilsh
Copy link
Copy Markdown

@sdwilsh sdwilsh commented Oct 29, 2025

Here are the commits I've got to update the devcontainer to use ufmt. This includes a change that will go away if you rebase your commits.

I didn't update the readme because I'm not sure what badge to use here, if I'm being honest.

I also don't think uvx works with vscode's settings, alas, so I have to setup a venv, which ended up being a giant pain to get working.

gemini-code-assist[bot]

This comment was marked as resolved.

Repository owner deleted a comment from gemini-code-assist Bot Oct 29, 2025
@ofek
Copy link
Copy Markdown
Owner

ofek commented Oct 29, 2025

Are you fine with me removing the manual Python management in favor of using uv which is already installed in the image? It would remove a lot of future maintenance on your part.

@sdwilsh
Copy link
Copy Markdown
Author

sdwilsh commented Oct 30, 2025

As long as it works well with vscode still, I don't really care.

The only potentially complicated part is that the requirements-fmt.txt file needs to exist (it's shared across Python-based projects at Meta), and that's how those deps will need to be managed.

Comment thread Justfile Outdated
Comment thread Justfile Outdated
Comment thread .devcontainer/Containerfile Outdated
Comment thread .devcontainer/devcontainer.json Outdated
Comment thread .devcontainer/devcontainer.json Outdated
Comment thread python/pyproject.toml Outdated
Comment thread python/pyproject.toml
Comment thread Justfile Outdated
Comment thread Justfile Outdated
Copy link
Copy Markdown
Owner

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ofek ofek merged commit 03b862a into ofek:python-package Oct 30, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants