Skip to content

Fix unused merge directive source string conversion#1046

Merged
oferchen merged 1 commit into
masterfrom
implement-missing-features-for-oc-rsync
Oct 24, 2025
Merged

Fix unused merge directive source string conversion#1046
oferchen merged 1 commit into
masterfrom
implement-missing-features-for-oc-rsync

Conversation

@oferchen
Copy link
Copy Markdown
Owner

Summary

  • reuse the precomputed merge directive source string when generating exclude-self rules to avoid redundant lossy conversions
  • this keeps the recorded pattern identical to the original directive text while eliminating the build warning

Parity Impact

  • Red → Green count: 0 → 0 (warning-only cleanup)
  • Affected goldens: None
  • Upstream reference: mirrors upstream handling of merge directives by preserving the caller-provided pattern text when --filter=':C' emits an implicit exclude

Testing

  • cargo fmt
  • cargo test -p rsync-cli --lib

https://chatgpt.com/codex/tasks/task_e_68fbaca1a80483238e0c222a8c5f2aee

@oferchen oferchen merged commit 6018e5f into master Oct 24, 2025
@oferchen oferchen deleted the implement-missing-features-for-oc-rsync branch October 24, 2025 16:50
oferchen added a commit that referenced this pull request May 7, 2026
Audit per-file syscall sequence across chown/chmod/utimensat/xattr/ACL
paths, document parallelism status (rayon batch only on directory
creation), and propose 5 reductions: cached-stat skip, fd-relative
ops on the streaming path, dirfd batching, attribute deduplication,
and a deferred metadata phase.
oferchen added a commit that referenced this pull request May 7, 2026
Audit per-file syscall sequence across chown/chmod/utimensat/xattr/ACL
paths, document parallelism status (rayon batch only on directory
creation), and propose 5 reductions: cached-stat skip, fd-relative
ops on the streaming path, dirfd batching, attribute deduplication,
and a deferred metadata phase.
oferchen added a commit that referenced this pull request May 7, 2026
Audit metadata apply pipeline (chmod/chown/utimensat/setxattr/setfacl),
quantify the 300K-syscall floor at 100K files, plan strace-c profiling,
confirm rayon par_iter wiring through apply_metadata_from_file_entry
(threshold 64), and enumerate io_uring statx, O_PATH fchownat, and
skip-if-equal optimization candidates.
oferchen added a commit that referenced this pull request May 18, 2026
Audit per-file syscall sequence across chown/chmod/utimensat/xattr/ACL
paths, document parallelism status (rayon batch only on directory
creation), and propose 5 reductions: cached-stat skip, fd-relative
ops on the streaming path, dirfd batching, attribute deduplication,
and a deferred metadata phase.
oferchen added a commit that referenced this pull request May 18, 2026
Audit metadata apply pipeline (chmod/chown/utimensat/setxattr/setfacl),
quantify the 300K-syscall floor at 100K files, plan strace-c profiling,
confirm rayon par_iter wiring through apply_metadata_from_file_entry
(threshold 64), and enumerate io_uring statx, O_PATH fchownat, and
skip-if-equal optimization candidates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant