Skip to content

Add aliases for session handshake part conversions#1049

Merged
oferchen merged 1 commit into
masterfrom
implement-missing-rsync-features
Oct 24, 2025
Merged

Add aliases for session handshake part conversions#1049
oferchen merged 1 commit into
masterfrom
implement-missing-rsync-features

Conversation

@oferchen
Copy link
Copy Markdown
Owner

Summary

  • add SessionHandshake::into_parts and SessionHandshake::from_parts so the aggregated session helper mirrors the variant-specific API shape
  • keep the legacy into_stream_parts/from_stream_parts entry points as thin aliases to maintain backwards compatibility
  • add focused tests ensuring the new aliases behave identically for binary and legacy negotiations

Testing

  • cargo test -q -p rsync-transport session_handshake_into_parts_aliases_method_for_binary
  • cargo test -q -p rsync-transport session_handshake_into_parts_aliases_method_for_legacy

https://chatgpt.com/codex/tasks/task_e_68fbb45ae9a0832394a8c7a89f4201b1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant