Skip to content

Allow whitespace in bandwidth limit arguments#1060

Merged
oferchen merged 1 commit into
masterfrom
implement-missing-components-for-oc-rsync
Oct 24, 2025
Merged

Allow whitespace in bandwidth limit arguments#1060
oferchen merged 1 commit into
masterfrom
implement-missing-components-for-oc-rsync

Conversation

@oferchen
Copy link
Copy Markdown
Owner

@oferchen oferchen commented Oct 24, 2025

Summary

  • trim ASCII whitespace around bandwidth limit specifications before parsing
  • ensure the CLI and daemon accept --bwlimit values with surrounding whitespace and cover the behaviour with tests

Testing

  • cargo test -p rsync-bandwidth
  • cargo test -p rsync-cli bwlimit_argument_trims_whitespace
  • cargo test -p rsync-daemon runtime_options_trim_bwlimit_argument

https://chatgpt.com/codex/tasks/task_e_68fbe20e0a3c8323a9cc021172a49c41

@oferchen oferchen merged commit f00d13c into master Oct 24, 2025
@oferchen oferchen deleted the implement-missing-components-for-oc-rsync branch October 24, 2025 20:41
This was referenced May 1, 2026
Merged
Merged
oferchen added a commit that referenced this pull request May 7, 2026
@oferchen
docs(design): shared io_uring instance for concurrent transfers (#3851)
4bfbba2 
Specifies a single session-owned io_uring shared by all concurrent
file transfers. Covers the per-batch ring baseline, ownership trade
offs (Arc<Mutex<Ring>> vs single-thread submitter), SQ partitioning
and the registered fd table, the dispatcher concurrency model, the
comparison with the #1409 ring pool, and a five-step migration plan.
Cites task #1060.
@oferchen oferchen mentioned this pull request May 7, 2026
Merged
3 tasks
oferchen added a commit that referenced this pull request May 7, 2026
@oferchen
docs(design): shared io_uring instance across concurrent transfers (#…
e58544b 
…1060) (#3922)

Specify a daemon-wide shared io_uring router that amortises ring setup
across concurrent in-flight transfers, extending the per-session ring
pool from #1408/#1409. Recommends gating behind a feature flag with
per-session pool as the default.
oferchen added a commit that referenced this pull request May 18, 2026
@oferchen
docs(design): shared io_uring instance for concurrent transfers (#3851)
5d03984 
Specifies a single session-owned io_uring shared by all concurrent
file transfers. Covers the per-batch ring baseline, ownership trade
offs (Arc<Mutex<Ring>> vs single-thread submitter), SQ partitioning
and the registered fd table, the dispatcher concurrency model, the
comparison with the #1409 ring pool, and a five-step migration plan.
Cites task #1060.
oferchen added a commit that referenced this pull request May 18, 2026
@oferchen
docs(design): shared io_uring instance across concurrent transfers (#…
b602349 
…1060) (#3922)

Specify a daemon-wide shared io_uring router that amortises ring setup
across concurrent in-flight transfers, extending the per-session ring
pool from #1408/#1409. Recommends gating behind a feature flag with
per-session pool as the default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@oferchen