Skip to content

Support leading signs in bwlimit parsing#1083

Merged
oferchen merged 1 commit into
masterfrom
implement-missing-components-for-oc-rsync-h33pl2
Oct 25, 2025
Merged

Support leading signs in bwlimit parsing#1083
oferchen merged 1 commit into
masterfrom
implement-missing-components-for-oc-rsync-h33pl2

Conversation

@oferchen
Copy link
Copy Markdown
Owner

Summary

  • allow the bandwidth parser to accept an optional leading "+" while treating negative rates as invalid
  • exercise the new behaviour with focused unit tests in both the bandwidth and CLI crates

Testing

  • cargo test -p rsync-bandwidth
  • cargo test -p rsync-cli bwlimit_accepts_leading_plus_sign
  • cargo test -p rsync-cli bwlimit_rejects_negative_values

https://chatgpt.com/codex/tasks/task_e_68fc132bc8388323ac2e22faec244448

@oferchen oferchen merged commit 13d69e4 into master Oct 25, 2025
@oferchen oferchen deleted the implement-missing-components-for-oc-rsync-h33pl2 branch October 25, 2025 00:13
oferchen added a commit that referenced this pull request May 7, 2026
Profile current PARALLEL_STAT_THRESHOLD and chunk sizing across receiver
and flist batched_stat paths, document rayon split behaviour at 16/64/256/1024/10K
file counts, and propose adaptive chunk size, per-FS-type tuning, and
work-stealing improvements.
oferchen added a commit that referenced this pull request May 7, 2026
…3906)

Capture the current per-operation parallel-stat thresholds, frame
the question of whether 64 still fits NFS/FUSE round-trip costs,
lay out a {16,64,256,1024,4096} x {100,1K,10K,100K} profiling
matrix across tmpfs/xfs/NFS/FUSE, and enumerate decision branches
(keep / runtime knob / statfs-aware) plus warmup, work-stealing,
NFS overload, and noise risks.
oferchen added a commit that referenced this pull request May 18, 2026
Profile current PARALLEL_STAT_THRESHOLD and chunk sizing across receiver
and flist batched_stat paths, document rayon split behaviour at 16/64/256/1024/10K
file counts, and propose adaptive chunk size, per-FS-type tuning, and
work-stealing improvements.
oferchen added a commit that referenced this pull request May 18, 2026
…3906)

Capture the current per-operation parallel-stat thresholds, frame
the question of whether 64 still fits NFS/FUSE round-trip costs,
lay out a {16,64,256,1024,4096} x {100,1K,10K,100K} profiling
matrix across tmpfs/xfs/NFS/FUSE, and enumerate decision branches
(keep / runtime knob / statfs-aware) plus warmup, work-stealing,
NFS overload, and noise risks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant