Add CLI debug flag handling and propagate to fallback#1084
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+221
to
222
| const SUPPORTED_OPTIONS_LIST: &str = "--help/-h, --version/-V, --daemon, --dry-run/-n, --list-only, --archive/-a, --delete/--del, --delete-before, --delete-during, --delete-delay, --delete-after, --checksum/-c, --size-only, --ignore-existing, --exclude, --exclude-from, --include, --include-from, --filter (including exclude-if-present=FILE), --files-from, --password-file, --no-motd, --from0, --bwlimit, --timeout, --protocol, --compress/-z, --no-compress, --compress-level, --info, --debug, --verbose/-v, --progress, --no-progress, --msgs2stderr, --itemize-changes/-i, --out-format, --stats, --partial, --partial-dir, --no-partial, --remove-source-files, --remove-sent-files, --inplace, --no-inplace, --whole-file/-W, --no-whole-file, -P, --sparse/-S, --no-sparse, --copy-links/-L, --copy-dirlinks/-k, --no-copy-links, -D, --devices, --no-devices, --specials, --no-specials, --owner, --no-owner, --group, --no-group, --perms/-p, --no-perms, --times/-t, --no-times, --acls/-A, --no-acls, --xattrs/-X, --no-xattrs, --numeric-ids, and --no-numeric-ids"; | ||
| const SUPPORTED_OPTIONS_LIST: &str = "--help/-h, --version/-V, --daemon, --dry-run/-n, --list-only, --archive/-a, --delete/--del, --delete-before, --delete-during, --delete-delay, --delete-after, --checksum/-c, --size-only, --ignore-existing, --exclude, --exclude-from, --include, --include-from, --filter (including exclude-if-present=FILE), --files-from, --password-file, --no-motd, --from0, --bwlimit, --timeout, --protocol, --rsync-path, --compress/-z, --no-compress, --compress-level, --info, --verbose/-v, --progress, --no-progress, --msgs2stderr, --itemize-changes/-i, --out-format, --stats, --partial, --partial-dir, --no-partial, --remove-source-files, --remove-sent-files, --inplace, --no-inplace, --whole-file/-W, --no-whole-file, -P, --sparse/-S, --no-sparse, --copy-links/-L, --copy-dirlinks/-k, --no-copy-links, -D, --devices, --no-devices, --specials, --no-specials, --owner, --no-owner, --group, --no-group, --perms/-p, --no-perms, --times/-t, --no-times, --acls/-A, --no-acls, --xattrs/-X, --no-xattrs, --numeric-ids, and --no-numeric-ids"; |
There was a problem hiding this comment.
Introducing a second const SUPPORTED_OPTIONS_LIST right after the existing one leaves two top‑level constants with the same name in lib.rs. Rust disallows multiple items sharing the same identifier in a module, so the crate will fail to compile before any of the new debug flag logic can run. Replace the existing declaration instead of adding another so the constants remain unique.
Useful? React with 👍 / 👎.
2 tasks
oferchen
added a commit
that referenced
this pull request
May 7, 2026
…#3828) Audit the 64-entry PARALLEL_STAT_THRESHOLD against high-latency filesystem semantics. Surveys NFS GETATTR cost, FUSE attribute caching, and server-side concurrency ceilings; proposes statfs-based detection, env var override, and CLI flag with auto/always/never modes.
This was referenced May 7, 2026
oferchen
added a commit
that referenced
this pull request
May 7, 2026
…3923) Design note motivating per-filesystem thresholds for the receiver's parallel stat refresh. Captures detection strategy via statfs magic numbers, a starting threshold table, an implementation sketch with a per-device cache, and the misdetection risks on bind mounts and overlay filesystems.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…#3828) Audit the 64-entry PARALLEL_STAT_THRESHOLD against high-latency filesystem semantics. Surveys NFS GETATTR cost, FUSE attribute caching, and server-side concurrency ceilings; proposes statfs-based detection, env var override, and CLI flag with auto/always/never modes.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…3923) Design note motivating per-filesystem thresholds for the receiver's parallel stat refresh. Captures detection strategy via statfs magic numbers, a starting threshold table, an implementation sketch with a per-device cache, and the misdetection risks on bind mounts and overlay filesystems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68fc1090c1848323a37c9d11acef17f9