Skip to content

Align decimal --bwlimit rounding with upstream behaviour#1292

Merged
oferchen merged 1 commit into
masterfrom
establish-coding-guidelines-for-rsync-rust-port
Oct 27, 2025
Merged

Align decimal --bwlimit rounding with upstream behaviour#1292
oferchen merged 1 commit into
masterfrom
establish-coding-guidelines-for-rsync-rust-port

Conversation

@oferchen
Copy link
Copy Markdown
Owner

Summary

  • track decimal suffix alignment in the bandwidth parser so MB/KB arguments round to decimal multiples instead of binary multiples
  • adjust unit tests in the bandwidth crate and CLI to assert the corrected decimal results

Testing

  • cargo test -p rsync-bandwidth
  • cargo test -p rsync-cli -- --test-threads=1 --quiet
  • cargo test -p rsync-core bandwidth_limit -- --nocapture
  • cargo test -p rsync-daemon bwlimit -- --nocapture

https://chatgpt.com/codex/tasks/task_e_68ffcf299fe08323b1297fa9bbe6e844

@oferchen oferchen merged commit 88beed2 into master Oct 27, 2025
@oferchen oferchen deleted the establish-coding-guidelines-for-rsync-rust-port branch October 27, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant