Skip to content

Handle truthy fallback overrides as default delegation#1303

Merged
oferchen merged 1 commit into
masterfrom
implement-missing-rsync-functionality
Oct 28, 2025
Merged

Handle truthy fallback overrides as default delegation#1303
oferchen merged 1 commit into
masterfrom
implement-missing-rsync-functionality

Conversation

@oferchen
Copy link
Copy Markdown
Owner

Summary

  • treat OC_RSYNC_FALLBACK and OC_RSYNC_DAEMON_FALLBACK values of 1, true, yes, or on as requests to use the default helper binary
  • document the interpretation alongside the existing boolean/auto cases and add regression coverage for the new behaviour

Testing

  • cargo test -p rsync-core fallback::

https://chatgpt.com/codex/tasks/task_e_69006bba45c48323bad3d8342dddbd89

@oferchen oferchen merged commit fe7e879 into master Oct 28, 2025
@oferchen oferchen deleted the implement-missing-rsync-functionality branch October 28, 2025 07:14
oferchen added a commit that referenced this pull request May 5, 2026
Design note for TODO #1193. Adds docs/design/protocol-fuzzing-harness.md
covering a behavioural differential fuzz harness that drives both
oc-rsync and upstream rsync 3.4.1 through randomized end-to-end
transfer scenarios and asserts equivalence on exit code, destination
tree bytes, wire payload (tcpdump), and stderr structure. Sister to
the wire-byte fuzz at crates/protocol/fuzz/ (#1194) and the wire-format
differential fuzzer at #1303.

Documents only. Zero impact on production code paths; the harness lives
in a new fuzz-harness crate outside the production dependency graph.
oferchen added a commit that referenced this pull request May 18, 2026
Design note for TODO #1193. Adds docs/design/protocol-fuzzing-harness.md
covering a behavioural differential fuzz harness that drives both
oc-rsync and upstream rsync 3.4.1 through randomized end-to-end
transfer scenarios and asserts equivalence on exit code, destination
tree bytes, wire payload (tcpdump), and stderr structure. Sister to
the wire-byte fuzz at crates/protocol/fuzz/ (#1194) and the wire-format
differential fuzzer at #1303.

Documents only. Zero impact on production code paths; the harness lives
in a new fuzz-harness crate outside the production dependency graph.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant