Skip to content

Ensure workspace protocol metadata matches protocol crate#1407

Merged
oferchen merged 1 commit into
masterfrom
prepare-for-production-release-uqlksm
Oct 28, 2025
Merged

Ensure workspace protocol metadata matches protocol crate#1407
oferchen merged 1 commit into
masterfrom
prepare-for-production-release-uqlksm

Conversation

@oferchen
Copy link
Copy Markdown
Owner

Summary

  • add a workspace::protocol_version_u8 helper that guarantees the manifest protocol fits in a byte
  • assert at compile time that the workspace metadata matches ProtocolVersion::NEWEST
  • use the new helper for HIGHEST_PROTOCOL_VERSION so version banners source a single authority

Testing

  • cargo test -p rsync-core workspace::tests::parse_protocol_matches_env -- --nocapture

https://chatgpt.com/codex/tasks/task_e_6900f7e84d4c8323a20daef966406a0d

@oferchen oferchen merged commit b950d17 into master Oct 28, 2025
@oferchen oferchen deleted the prepare-for-production-release-uqlksm branch October 28, 2025 17:16
oferchen added a commit that referenced this pull request May 7, 2026
Concise design for a receiver-side multi-file delta-apply pipeline
that overlaps per-file apply across in-flight files while preserving
strict wire-NDX order at acknowledgement and disk-commit boundaries.
Composes the existing ReceiverDeltaPipeline trait (#1543), bounded
work queue, and BoundedReorderBuffer (#1407). Threshold gate at
PARALLEL_STAT_THRESHOLD=64 (#1547). Risks documented: head-of-line
stall (#1883) and spill-to-tempfile pending (#1884).
oferchen added a commit that referenced this pull request May 18, 2026
Concise design for a receiver-side multi-file delta-apply pipeline
that overlaps per-file apply across in-flight files while preserving
strict wire-NDX order at acknowledgement and disk-commit boundaries.
Composes the existing ReceiverDeltaPipeline trait (#1543), bounded
work queue, and BoundedReorderBuffer (#1407). Threshold gate at
PARALLEL_STAT_THRESHOLD=64 (#1547). Risks documented: head-of-line
stall (#1883) and spill-to-tempfile pending (#1884).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant