Fix clippy warnings across workspace#1412
Merged
Merged
Conversation
oferchen
added a commit
that referenced
this pull request
May 17, 2026
…4226) Captures the wrapper-level design for swapping the SSH subprocess stdio onto tokio::process::Child stdio. Records why tokio::process is preferred over a raw AsyncFd construction, what async actually buys beyond today's thread-per-half overlap (thread elimination, collapsed stderr drain and connect watchdog), the parallel AsyncSshConnection surface, a sync-vs-async bench matrix anchored on the 1 MB/s emulated link from #1889, and a recommendation to defer the implementation until the async daemon (#1935) lands so runtime ownership is settled first.
4 tasks
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…4226) Captures the wrapper-level design for swapping the SSH subprocess stdio onto tokio::process::Child stdio. Records why tokio::process is preferred over a raw AsyncFd construction, what async actually buys beyond today's thread-per-half overlap (thread elimination, collapsed stderr drain and connect watchdog), the parallel AsyncSshConnection surface, a sync-vs-async bench matrix anchored on the 1 MB/s emulated link from #1889, and a recommendation to defer the implementation until the async daemon (#1935) lands so runtime ownership is settled first.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…4226) Captures the wrapper-level design for swapping the SSH subprocess stdio onto tokio::process::Child stdio. Records why tokio::process is preferred over a raw AsyncFd construction, what async actually buys beyond today's thread-per-half overlap (thread elimination, collapsed stderr drain and connect watchdog), the parallel AsyncSshConnection surface, a sync-vs-async bench matrix anchored on the 1 MB/s emulated link from #1889, and a recommendation to defer the implementation until the async daemon (#1935) lands so runtime ownership is settled first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_6900fd45a760832381a08a867a09e702