Inline protocol table validation const#1573
Merged
oferchen merged 1 commit intoOct 29, 2025
Merged
Conversation
oferchen
deleted the
fix-unused-function-warning-in-validate_protocol_tables
branch
This was referenced May 5, 2026
oferchen
added a commit
that referenced
this pull request
May 7, 2026
… WorkQueue (#1573) (#3883) Capture the design tradeoffs for fanning out generator source enumeration across the existing multi-producer WorkQueue infrastructure: current single-producer walk path, multi-root scenarios, sender contract, NDX/hardlink/io_error/INC_RECURSE risks, and a prototype gate via --parallel-enumerate.
Merged
3 tasks
oferchen
added a commit
that referenced
this pull request
May 17, 2026
… WorkQueue (#1573) (#4207) Engages with the #4173 audit conclusion that WorkQueueSender stays single-producer. Shows I1 (#2196) is the wrong instrument for the first-byte hypothesis - enumeration runs before send_file_list entry, so I1 excludes it by construction. Recommends defer pending a W1 benchmark (process start to first inbound flist byte) on multi-root cold-cache workloads.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
… WorkQueue (#1573) (#3883) Capture the design tradeoffs for fanning out generator source enumeration across the existing multi-producer WorkQueue infrastructure: current single-producer walk path, multi-root scenarios, sender contract, NDX/hardlink/io_error/INC_RECURSE risks, and a prototype gate via --parallel-enumerate.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
… WorkQueue (#1573) (#4207) Engages with the #4173 audit conclusion that WorkQueueSender stays single-producer. Shows I1 (#2196) is the wrong instrument for the first-byte hypothesis - enumeration runs before send_file_list entry, so I1 excludes it by construction. Recommends defer pending a W1 benchmark (process start to first inbound flist byte) on multi-root cold-cache workloads.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
… WorkQueue (#1573) (#4207) Engages with the #4173 audit conclusion that WorkQueueSender stays single-producer. Shows I1 (#2196) is the wrong instrument for the first-byte hypothesis - enumeration runs before send_file_list entry, so I1 excludes it by construction. Recommends defer pending a W1 benchmark (process start to first inbound flist byte) on multi-root cold-cache workloads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
protocol_versionTesting
https://chatgpt.com/codex/tasks/task_e_69026dfe5444832392569eee82b8a078