Skip to content

Fix Windows GNU exports and improve coverage enforcement#1683

Merged
oferchen merged 1 commit into
masterfrom
fix-ci-errors-and-improve-best-practices
Oct 30, 2025
Merged

Fix Windows GNU exports and improve coverage enforcement#1683
oferchen merged 1 commit into
masterfrom
fix-ci-errors-and-improve-best-practices

Conversation

@oferchen
Copy link
Copy Markdown
Owner

Summary

  • wrap the Windows GNU exception helpers with #[unsafe(no_mangle)] to satisfy Rust 1.87's safety requirements
  • add a reusable coverage enforcement script that prints summary metrics before comparing thresholds
  • update the CI workflow to generate JSON and lcov coverage reports, then validate coverage via the new script

Testing

  • cargo check -p rsync-windows-gnu-eh
  • python3 tools/check_coverage.py /tmp/coverage-summary.json --min-lines 95 --min-functions 95

https://chatgpt.com/codex/tasks/task_e_69035c94d724832395720bcd830fb075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant