Split CopyContext implementation into modular include files#1759
Merged
Conversation
This was referenced May 13, 2026
oferchen
added a commit
that referenced
this pull request
May 14, 2026
…e-buffered (#4033) Task #1759 asked for double-buffering in the retained checksum pipeline. The work is already done in `crates/checksums/src/pipelined/`: the reader pre-allocates two buffers, seeds one into a recycle channel, and uses a bounded `sync_channel(1)` so the I/O thread reads block N+1 while the caller hashes block N. Functional parity with the serialized hasher is covered by unit and proptest cases. This audit documents where the implementation lives, the two-buffer invariant, the sync fallback, and the existing test coverage so future contributors do not reintroduce a parallel primitive.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…e-buffered (#4033) Task #1759 asked for double-buffering in the retained checksum pipeline. The work is already done in `crates/checksums/src/pipelined/`: the reader pre-allocates two buffers, seeds one into a recycle channel, and uses a bounded `sync_channel(1)` so the I/O thread reads block N+1 while the caller hashes block N. Functional parity with the serialized hasher is covered by unit and proptest cases. This audit documents where the implementation lives, the two-buffer invariant, the sync fallback, and the existing test coverage so future contributors do not reintroduce a parallel primitive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CopyContextinherent impl into include! fragments undercontext_impl/to keep each file within hygiene limitscontext.rsto reference the new parts while preserving the existing preamble/postamble layoutinternal docsTesting
https://chatgpt.com/codex/tasks/task_e_6904b750a80c8323a2833cdc5725f364