Fix split_shell_words handling of empty quoted arguments#1840
Merged
Conversation
3 tasks
oferchen
added a commit
that referenced
this pull request
Apr 29, 2026
…3424) Maps every upstream rsync 3.4.1 iconv call site (in flist.c, io.c, rsync.c, log.c, compat.c) to its oc-rsync counterpart and flags the gaps. Findings: - Critical: --iconv is end-to-end inert because no production code converts IconvSetting into a FilenameConverter or calls ServerConfigBuilder::iconv(...). - High: receiver and sender symlink targets bypass iconv (flist read/write extras). - High: --files-from forwarding and --secluded-args/--protect-args bypass iconv on both sides. - Medium: capability string unconditionally advertises 's' (CF_SYMLINK_ICONV) regardless of iconv configuration. - Low: log lines are not transcoded. The set is interlocked, so this PR ships the audit document only and links follow-ups for each finding rather than making a partial change.
3 tasks
oferchen
added a commit
that referenced
this pull request
May 1, 2026
…3424) Maps every upstream rsync 3.4.1 iconv call site (in flist.c, io.c, rsync.c, log.c, compat.c) to its oc-rsync counterpart and flags the gaps. Findings: - Critical: --iconv is end-to-end inert because no production code converts IconvSetting into a FilenameConverter or calls ServerConfigBuilder::iconv(...). - High: receiver and sender symlink targets bypass iconv (flist read/write extras). - High: --files-from forwarding and --secluded-args/--protect-args bypass iconv on both sides. - Medium: capability string unconditionally advertises 's' (CF_SYMLINK_ICONV) regardless of iconv configuration. - Low: log lines are not transcoded. The set is interlocked, so this PR ships the audit document only and links follow-ups for each finding rather than making a partial change.
oferchen
added a commit
that referenced
this pull request
May 5, 2026
…3424) Maps every upstream rsync 3.4.1 iconv call site (in flist.c, io.c, rsync.c, log.c, compat.c) to its oc-rsync counterpart and flags the gaps. Findings: - Critical: --iconv is end-to-end inert because no production code converts IconvSetting into a FilenameConverter or calls ServerConfigBuilder::iconv(...). - High: receiver and sender symlink targets bypass iconv (flist read/write extras). - High: --files-from forwarding and --secluded-args/--protect-args bypass iconv on both sides. - Medium: capability string unconditionally advertises 's' (CF_SYMLINK_ICONV) regardless of iconv configuration. - Low: log lines are not transcoded. The set is interlocked, so this PR ships the audit document only and links follow-ups for each finding rather than making a partial change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
split_shell_wordspreserves empty arguments emitted by empty quotesTesting
https://chatgpt.com/codex/tasks/task_e_6905680d93608323a54fa37f68fd4ae0