Fix RPM spec to use libexec paths for compatibility binaries#1851
Merged
Conversation
oferchen
added a commit
that referenced
this pull request
May 3, 2026
…rsa) The new `embedded-ssh` facade on the workspace root (PR #3569 first commit) makes `cargo-deny --all-features` walk the russh subgraph, which surfaces RUSTSEC-2023-0071 (timing side-channel in rsa 0.9.x). Scope: - Reaches oc-rsync only through the opt-in `embedded-ssh` feature (`russh-keys 0.45.0` -> `rsa 0.9.10`); default builds are unaffected. - No safe upstream upgrade is currently available. RustCrypto/RSA tracks the constant-time rewrite at RustCrypto/RSA#626. - Re-evaluate this allowlist entry once the russh 0.60.x bump (memory task #1851) lands and pulls in a fixed `rsa` crate.
oferchen
added a commit
that referenced
this pull request
May 3, 2026
* fix(workspace): expose embedded-ssh facade feature on root crate
The benchmark workflow (.github/workflows/benchmark.yml:60) builds
`cargo build --release --features embedded-ssh` against the workspace
root `bin` crate, but the root Cargo.toml exposed no `embedded-ssh`
facade, so cargo failed with:
error: the package 'bin' does not contain this feature: embedded-ssh
help: packages with the missing feature: core, rsync_io
Add the facade following the existing pattern (mirrors `iconv` /
`openssl` forwarding). `core/embedded-ssh` already chains into
`rsync_io/embedded-ssh` and pulls in tokio/russh, so a one-line
forward is sufficient.
* fix(deps): allowlist RUSTSEC-2023-0071 (Marvin Attack via russh-keys/rsa)
The new `embedded-ssh` facade on the workspace root (PR #3569 first
commit) makes `cargo-deny --all-features` walk the russh subgraph,
which surfaces RUSTSEC-2023-0071 (timing side-channel in rsa 0.9.x).
Scope:
- Reaches oc-rsync only through the opt-in `embedded-ssh` feature
(`russh-keys 0.45.0` -> `rsa 0.9.10`); default builds are unaffected.
- No safe upstream upgrade is currently available. RustCrypto/RSA
tracks the constant-time rewrite at
RustCrypto/RSA#626.
- Re-evaluate this allowlist entry once the russh 0.60.x bump (memory
task #1851) lands and pulls in a fixed `rsa` crate.
6 tasks
oferchen
added a commit
that referenced
this pull request
May 4, 2026
…wlist (#1851) (#3610) * chore(deps): bump russh 0.45 -> 0.60.1, drop GHSA-f5v4-2wr6-hqmg allowlist (#1851) Retires the Marvin Attack timing side-channel (GHSA-f5v4-2wr6-hqmg / RUSTSEC-2023-0071) by upgrading russh to 0.60.x, which transitively pulls rsa 0.10 (constant-time rewrite). The advisory ignore entry in deny.toml is removed; the embedded-ssh feature is now clean. Notable upstream API changes pulled in: - russh-keys merged into russh::keys (ssh-key types are re-exported there as PublicKey / PrivateKey via the russh fork of ssh-key). - async fn in traits replaces #[async_trait]; the async-trait crate is no longer needed for client::Handler / server::Handler impls. - Public-key auth requires PrivateKeyWithHashAlg to disambiguate RSA hash algorithms. - Authenticate calls return AuthResult with .success() instead of bool. - Handle::data takes Bytes/Into<Bytes>; the explicit CryptoVec wrapping is gone. - Server::run_on_socket no longer returns Result. Files touched: - Cargo.toml: workspace pin russh = "0.60.1", drop async-trait, russh-keys, ssh-key. - crates/rsync_io/Cargo.toml: drop async-trait/russh-keys/ssh-key from the embedded-ssh feature; add rand 0.10 dev-dep for test key gen. - crates/rsync_io/src/ssh/embedded/handler.rs: use russh::keys::{HashAlg, PublicKey, known_hosts}; native async fn check_server_key; SHA-256 fingerprints via key.fingerprint(HashAlg::Sha256); algorithm name via key.algorithm(). - crates/rsync_io/src/ssh/embedded/auth.rs: AgentClient flow uses identity.public_key().into_owned(); identity-file auth wraps keys in PrivateKeyWithHashAlg::new(Arc::new(key), None); password/pubkey checks inspect AuthResult::success(); mock server uses Auth::reject() and PrivateKey::random(&mut rand::rng(), Algorithm::Ed25519). - crates/rsync_io/src/ssh/embedded/connect.rs: Handle::data accepts Vec<u8> directly via Into<Bytes>; CryptoVec wrap removed. - deny.toml: drop RUSTSEC-2023-0071 from advisories.ignore. - docs/audits/ssh-transport-timeout-coverage.md: update russh_keys path reference to russh::keys. CI must pass on all required matrices (fmt+clippy, nextest stable, Windows, macOS, Linux musl, cargo-deny). Closes #1851 * style: cargo fmt --all * fix(deny): re-add RUSTSEC-2023-0071 allowlist for rsa 0.10 RC russh 0.60.x transitively pulls rsa 0.10.0-rc.16 (the constant-time rewrite tracked at RustCrypto/RSA#626), but the rustsec advisory has not been updated to mark 0.10 as patched -- there is no stable 0.10 release yet, only release candidates -- so cargo-deny still flags RUSTSEC-2023-0071 and fails CI. Restore the allowlist with an updated comment explaining the new state. The russh bump is still a net win: smaller dep graph, removes async-trait and standalone russh-keys/ssh-key, and positions us to retire the allowlist the moment rsa 0.10 ships stable. Reaches us only via the opt-in `embedded-ssh` feature; default builds are unaffected.
oferchen
added a commit
that referenced
this pull request
May 5, 2026
* fix(workspace): expose embedded-ssh facade feature on root crate
The benchmark workflow (.github/workflows/benchmark.yml:60) builds
`cargo build --release --features embedded-ssh` against the workspace
root `bin` crate, but the root Cargo.toml exposed no `embedded-ssh`
facade, so cargo failed with:
error: the package 'bin' does not contain this feature: embedded-ssh
help: packages with the missing feature: core, rsync_io
Add the facade following the existing pattern (mirrors `iconv` /
`openssl` forwarding). `core/embedded-ssh` already chains into
`rsync_io/embedded-ssh` and pulls in tokio/russh, so a one-line
forward is sufficient.
* fix(deps): allowlist RUSTSEC-2023-0071 (Marvin Attack via russh-keys/rsa)
The new `embedded-ssh` facade on the workspace root (PR #3569 first
commit) makes `cargo-deny --all-features` walk the russh subgraph,
which surfaces RUSTSEC-2023-0071 (timing side-channel in rsa 0.9.x).
Scope:
- Reaches oc-rsync only through the opt-in `embedded-ssh` feature
(`russh-keys 0.45.0` -> `rsa 0.9.10`); default builds are unaffected.
- No safe upstream upgrade is currently available. RustCrypto/RSA
tracks the constant-time rewrite at
RustCrypto/RSA#626.
- Re-evaluate this allowlist entry once the russh 0.60.x bump (memory
task #1851) lands and pulls in a fixed `rsa` crate.
oferchen
added a commit
that referenced
this pull request
May 5, 2026
…wlist (#1851) (#3610) * chore(deps): bump russh 0.45 -> 0.60.1, drop GHSA-f5v4-2wr6-hqmg allowlist (#1851) Retires the Marvin Attack timing side-channel (GHSA-f5v4-2wr6-hqmg / RUSTSEC-2023-0071) by upgrading russh to 0.60.x, which transitively pulls rsa 0.10 (constant-time rewrite). The advisory ignore entry in deny.toml is removed; the embedded-ssh feature is now clean. Notable upstream API changes pulled in: - russh-keys merged into russh::keys (ssh-key types are re-exported there as PublicKey / PrivateKey via the russh fork of ssh-key). - async fn in traits replaces #[async_trait]; the async-trait crate is no longer needed for client::Handler / server::Handler impls. - Public-key auth requires PrivateKeyWithHashAlg to disambiguate RSA hash algorithms. - Authenticate calls return AuthResult with .success() instead of bool. - Handle::data takes Bytes/Into<Bytes>; the explicit CryptoVec wrapping is gone. - Server::run_on_socket no longer returns Result. Files touched: - Cargo.toml: workspace pin russh = "0.60.1", drop async-trait, russh-keys, ssh-key. - crates/rsync_io/Cargo.toml: drop async-trait/russh-keys/ssh-key from the embedded-ssh feature; add rand 0.10 dev-dep for test key gen. - crates/rsync_io/src/ssh/embedded/handler.rs: use russh::keys::{HashAlg, PublicKey, known_hosts}; native async fn check_server_key; SHA-256 fingerprints via key.fingerprint(HashAlg::Sha256); algorithm name via key.algorithm(). - crates/rsync_io/src/ssh/embedded/auth.rs: AgentClient flow uses identity.public_key().into_owned(); identity-file auth wraps keys in PrivateKeyWithHashAlg::new(Arc::new(key), None); password/pubkey checks inspect AuthResult::success(); mock server uses Auth::reject() and PrivateKey::random(&mut rand::rng(), Algorithm::Ed25519). - crates/rsync_io/src/ssh/embedded/connect.rs: Handle::data accepts Vec<u8> directly via Into<Bytes>; CryptoVec wrap removed. - deny.toml: drop RUSTSEC-2023-0071 from advisories.ignore. - docs/audits/ssh-transport-timeout-coverage.md: update russh_keys path reference to russh::keys. CI must pass on all required matrices (fmt+clippy, nextest stable, Windows, macOS, Linux musl, cargo-deny). Closes #1851 * style: cargo fmt --all * fix(deny): re-add RUSTSEC-2023-0071 allowlist for rsa 0.10 RC russh 0.60.x transitively pulls rsa 0.10.0-rc.16 (the constant-time rewrite tracked at RustCrypto/RSA#626), but the rustsec advisory has not been updated to mark 0.10 as patched -- there is no stable 0.10 release yet, only release candidates -- so cargo-deny still flags RUSTSEC-2023-0071 and fails CI. Restore the allowlist with an updated comment explaining the new state. The russh bump is still a net win: smaller dep graph, removes async-trait and standalone russh-keys/ssh-key, and positions us to retire the allowlist the moment rsa 0.10 ships stable. Reaches us only via the opt-in `embedded-ssh` feature; default builds are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_6905728675608323ad65b9ca87c0254f