Gate alternatives registration and centralize tarball target metadata#1859
Closed
oferchen wants to merge 1 commit into
Closed
Gate alternatives registration and centralize tarball target metadata#1859oferchen wants to merge 1 commit into
oferchen wants to merge 1 commit into
Conversation
oferchen
deleted the
allow-side-by-side-installation-of-oc-rsync-and-rsync
branch
5 tasks
oferchen
added a commit
that referenced
this pull request
Apr 28, 2026
…ine (#3418) Adds two doc-only notes covering recurring questions: - crates/rsync_io/src/ssh/mod.rs: explains why SSH transfers cannot use the fast_io socket reader/writer paths. The data channel is the inherited stdio pipe pair from the spawned ssh child, not an AF_INET socket, so the io_uring socket fast path is unreachable. Mirrors upstream main.c:504 do_cmd(). Cross-references tasks #1859 (pipe-FD io_uring) and #1860 (splice-based zero-copy) and notes that daemon TCP and local-disk transfers still benefit from fast_io. - crates/transfer/src/generator/mod.rs: documents the sender-side INC_RECURSE state machine (Idle -> ScanDir -> SendChunk -> WaitAck -> NextDir -> Done) with upstream citations to flist.c:2192 send_file_list(), sender.c:199 send_files(), generator.c:2226 generate_files(), receiver.c:522 recv_files(), and compat.c:161 set_allow_inc_recurse(). Documents that the sender side is implemented but disabled in build_capability_string until interop is validated (task #1862); the 'i' capability is not advertised when oc-rsync is sender. Closes #1858, #1865.
oferchen
added a commit
that referenced
this pull request
Apr 29, 2026
oferchen
added a commit
that referenced
this pull request
May 1, 2026
…ine (#3418) Adds two doc-only notes covering recurring questions: - crates/rsync_io/src/ssh/mod.rs: explains why SSH transfers cannot use the fast_io socket reader/writer paths. The data channel is the inherited stdio pipe pair from the spawned ssh child, not an AF_INET socket, so the io_uring socket fast path is unreachable. Mirrors upstream main.c:504 do_cmd(). Cross-references tasks #1859 (pipe-FD io_uring) and #1860 (splice-based zero-copy) and notes that daemon TCP and local-disk transfers still benefit from fast_io. - crates/transfer/src/generator/mod.rs: documents the sender-side INC_RECURSE state machine (Idle -> ScanDir -> SendChunk -> WaitAck -> NextDir -> Done) with upstream citations to flist.c:2192 send_file_list(), sender.c:199 send_files(), generator.c:2226 generate_files(), receiver.c:522 recv_files(), and compat.c:161 set_allow_inc_recurse(). Documents that the sender side is implemented but disabled in build_capability_string until interop is validated (task #1862); the 'i' capability is not advertised when oc-rsync is sender. Closes #1858, #1865.
oferchen
added a commit
that referenced
this pull request
May 1, 2026
This was referenced May 1, 2026
oferchen
added a commit
that referenced
this pull request
May 1, 2026
Document the scope of #1593 (async at the transport-level) versus the parallel #1411 (async runtime adoption). Defer the Linux pipe-FD path to #1859, recommend status quo on macOS / BSD / Windows / older Linux, and articulate why the rsync wire-protocol pipeline single-threading caps the win regardless of mechanism.
8 tasks
oferchen
added a commit
that referenced
this pull request
May 5, 2026
…ine (#3418) Adds two doc-only notes covering recurring questions: - crates/rsync_io/src/ssh/mod.rs: explains why SSH transfers cannot use the fast_io socket reader/writer paths. The data channel is the inherited stdio pipe pair from the spawned ssh child, not an AF_INET socket, so the io_uring socket fast path is unreachable. Mirrors upstream main.c:504 do_cmd(). Cross-references tasks #1859 (pipe-FD io_uring) and #1860 (splice-based zero-copy) and notes that daemon TCP and local-disk transfers still benefit from fast_io. - crates/transfer/src/generator/mod.rs: documents the sender-side INC_RECURSE state machine (Idle -> ScanDir -> SendChunk -> WaitAck -> NextDir -> Done) with upstream citations to flist.c:2192 send_file_list(), sender.c:199 send_files(), generator.c:2226 generate_files(), receiver.c:522 recv_files(), and compat.c:161 set_allow_inc_recurse(). Documents that the sender side is implemented but disabled in build_capability_string until interop is validated (task #1862); the 'i' capability is not advertised when oc-rsync is sender. Closes #1858, #1865.
oferchen
added a commit
that referenced
this pull request
May 5, 2026
oferchen
added a commit
that referenced
this pull request
May 5, 2026
Document the scope of #1593 (async at the transport-level) versus the parallel #1411 (async runtime adoption). Defer the Linux pipe-FD path to #1859, recommend status quo on macOS / BSD / Windows / older Linux, and articulate why the rsync wire-protocol pipeline single-threading caps the win regardless of mechanism.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_69057bcc17ec8323ba7ba16756c02528