Handle missing tarball cross-compilers gracefully#1882
Merged
Conversation
5 tasks
oferchen
added a commit
that referenced
this pull request
May 1, 2026
Verifies that --jump-host=<value> propagates as `-J <value>` to the spawned SSH subprocess in the correct argv position (before the destination operand). A POSIX shell-script wrapper named `ssh` records its argv to a temp file and exits 255 so we can assert the wire-level contract without standing up a real two-hop sshd topology. Scenarios covered: - single hop: --jump-host=bastion.example.com - multi-hop chain: --jump-host=alice@a,bob@b - host with port: --jump-host=user@bastion:2200 - absent flag: no -J emitted - empty value: no -J emitted An end-to-end test that exercises a real two-hop SSH transfer through localhost is included but marked #[ignore] (requires sshd + remote rsync). The whole module is #[cfg(unix)] - the recorder relies on a Bourne shell wrapper. Closes #1882; references #1881 (implementation).
oferchen
added a commit
that referenced
this pull request
May 1, 2026
Verifies that --jump-host=<value> propagates as `-J <value>` to the spawned SSH subprocess in the correct argv position (before the destination operand). A POSIX shell-script wrapper named `ssh` records its argv to a temp file and exits 255 so we can assert the wire-level contract without standing up a real two-hop sshd topology. Scenarios covered: - single hop: --jump-host=bastion.example.com - multi-hop chain: --jump-host=alice@a,bob@b - host with port: --jump-host=user@bastion:2200 - absent flag: no -J emitted - empty value: no -J emitted An end-to-end test that exercises a real two-hop SSH transfer through localhost is included but marked #[ignore] (requires sshd + remote rsync). The whole module is #[cfg(unix)] - the recorder relies on a Bourne shell wrapper. Closes #1882; references #1881 (implementation).
oferchen
added a commit
that referenced
this pull request
May 2, 2026
Verifies that --jump-host=<value> propagates as `-J <value>` to the spawned SSH subprocess in the correct argv position (before the destination operand). A POSIX shell-script wrapper named `ssh` records its argv to a temp file and exits 255 so we can assert the wire-level contract without standing up a real two-hop sshd topology. Scenarios covered: - single hop: --jump-host=bastion.example.com - multi-hop chain: --jump-host=alice@a,bob@b - host with port: --jump-host=user@bastion:2200 - absent flag: no -J emitted - empty value: no -J emitted An end-to-end test that exercises a real two-hop SSH transfer through localhost is included but marked #[ignore] (requires sshd + remote rsync). The whole module is #[cfg(unix)] - the recorder relies on a Bourne shell wrapper. Closes #1882; references #1881 (implementation).
oferchen
added a commit
that referenced
this pull request
May 2, 2026
Verifies that --jump-host=<value> propagates as `-J <value>` to the spawned SSH subprocess in the correct argv position (before the destination operand). A POSIX shell-script wrapper named `ssh` records its argv to a temp file and exits 255 so we can assert the wire-level contract without standing up a real two-hop sshd topology. Scenarios covered: - single hop: --jump-host=bastion.example.com - multi-hop chain: --jump-host=alice@a,bob@b - host with port: --jump-host=user@bastion:2200 - absent flag: no -J emitted - empty value: no -J emitted An end-to-end test that exercises a real two-hop SSH transfer through localhost is included but marked #[ignore] (requires sshd + remote rsync). The whole module is #[cfg(unix)] - the recorder relies on a Bourne shell wrapper. Closes #1882; references #1881 (implementation).
oferchen
added a commit
that referenced
this pull request
May 5, 2026
Verifies that --jump-host=<value> propagates as `-J <value>` to the spawned SSH subprocess in the correct argv position (before the destination operand). A POSIX shell-script wrapper named `ssh` records its argv to a temp file and exits 255 so we can assert the wire-level contract without standing up a real two-hop sshd topology. Scenarios covered: - single hop: --jump-host=bastion.example.com - multi-hop chain: --jump-host=alice@a,bob@b - host with port: --jump-host=user@bastion:2200 - absent flag: no -J emitted - empty value: no -J emitted An end-to-end test that exercises a real two-hop SSH transfer through localhost is included but marked #[ignore] (requires sshd + remote rsync). The whole module is #[cfg(unix)] - the recorder relies on a Bourne shell wrapper. Closes #1882; references #1881 (implementation).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_69061bd85f6c832385f14a21dcaf8cd8