Skip to content

Fix clippy warning in sparse executor test#1936

Merged
oferchen merged 1 commit into
masterfrom
fix-clippy-warnings-in-rsync-engine
Nov 4, 2025
Merged

Fix clippy warning in sparse executor test#1936
oferchen merged 1 commit into
masterfrom
fix-clippy-warnings-in-rsync-engine

Conversation

@oferchen
Copy link
Copy Markdown
Owner

@oferchen oferchen commented Nov 4, 2025

Summary

  • update the sparse executor zero-run length test assertion to use inline format arguments compatible with clippy

Testing

  • cargo clippy --workspace --all-targets --all-features --no-deps -- -D warnings

https://chatgpt.com/codex/tasks/task_e_6909b847139c83238bc8c87bb83f2b88

@oferchen oferchen merged commit 32f48c2 into master Nov 4, 2025
@oferchen oferchen deleted the fix-clippy-warnings-in-rsync-engine branch November 4, 2025 08:48
This was referenced May 1, 2026
Merged
Merged
Merged
oferchen added a commit that referenced this pull request May 7, 2026
@oferchen
docs(design): wire io_uring socket I/O into daemon TCP (#1876) (#3875)
9808b7d 
Plan replaces std and tokio TcpStream halves in the daemon accept
loop with the io_uring socket reader/writer adapters once the shared
session ring (#1874) and per-session ring pool (#1936/#1937) land,
reusing the POLLOUT linked-timeout fix from #1872.
oferchen added a commit that referenced this pull request May 7, 2026
@oferchen
docs(design): per-session io_uring ring pool impl plan (#1937) (#3876)
0e808a4 
Concrete plan to finish #1408/#1409: lookup `RingPool` by `SessionId`,
tie ring lifetime to session drop via `SessionRegistry::unregister`,
and migrate sockets, disk_batch, and copy_file_range to the shared
path. Cites #1936 for the per-session lookup contract.
@oferchen oferchen mentioned this pull request May 7, 2026
Merged
2 tasks
oferchen added a commit that referenced this pull request May 7, 2026
@oferchen
docs(audits): bound io_uring bgid u16 namespace exhaustion (#2044) (#…
39f33b4 
…3894)

Document that buffer-group ids are u16 in io_uring (max 65 535 per
ring), audit current `BufferRing` lifecycle (kernel reclaims via
`IORING_UNREGISTER_PBUF_RING` on drop, but no in-process allocator
owns the namespace), sketch the long-running daemon worst case, and
propose a hard-capped slab allocator with telemetry and a typed
exhaustion error before #1936 / #1937 wire PBUF_RING through the
per-session ring.
oferchen added a commit that referenced this pull request May 13, 2026
@oferchen
docs: design per-session io_uring ring pool footprint controls (#1936)
46da8ba 
Adds the per-session ring pool design that focuses on reducing
per-process io_uring memory cost when many oc-rsync invocations run
concurrently. Surveys current ring construction, names the four
in-scope levers (lazy ring construction, adaptive registered-buffer
count, soft cap via CLI/env, probe-cache invariant), and sequences
them as independent PRs.
@oferchen oferchen mentioned this pull request May 13, 2026
Merged
3 tasks
oferchen added a commit that referenced this pull request May 13, 2026
@oferchen
docs: design per-session io_uring ring pool footprint controls (#1936) (
c3c77b9 
#4014)

Adds the per-session ring pool design that focuses on reducing
per-process io_uring memory cost when many oc-rsync invocations run
concurrently. Surveys current ring construction, names the four
in-scope levers (lazy ring construction, adaptive registered-buffer
count, soft cap via CLI/env, probe-cache invariant), and sequences
them as independent PRs.
This was referenced May 14, 2026
Merged
Merged
Merged
Merged
oferchen added a commit that referenced this pull request May 17, 2026
@oferchen
docs(audits): BGID lifecycle + exhaustion risk (#2293, #2294) (#4331)
0f711a6 
Catalogues the allocation site (BgidAllocator::allocate at
crates/fast_io/src/io_uring/buffer_ring.rs:193) and the release site
(BufferRing::Drop at buffer_ring.rs:720, deallocate at :245).
Pins BgidExhausted definition (io_uring_common.rs:370) and the two
raise sites. Identifies the gap that BGE-3 and BGE-4 need to close:
no peak telemetry, unbounded free-list, no in-tree caller (production
PBUF wiring is still pending under #1936/#1937). Lays out the
free-list pool + Drop signal recycling plan for BGE-4 and the
churn / loom / recovery stress matrix for BGE-5.
oferchen added a commit that referenced this pull request May 18, 2026
@oferchen
docs(design): wire io_uring socket I/O into daemon TCP (#1876) (#3875)
77ee8be 
Plan replaces std and tokio TcpStream halves in the daemon accept
loop with the io_uring socket reader/writer adapters once the shared
session ring (#1874) and per-session ring pool (#1936/#1937) land,
reusing the POLLOUT linked-timeout fix from #1872.
oferchen added a commit that referenced this pull request May 18, 2026
@oferchen
docs(design): per-session io_uring ring pool impl plan (#1937) (#3876)
344a2eb 
Concrete plan to finish #1408/#1409: lookup `RingPool` by `SessionId`,
tie ring lifetime to session drop via `SessionRegistry::unregister`,
and migrate sockets, disk_batch, and copy_file_range to the shared
path. Cites #1936 for the per-session lookup contract.
oferchen added a commit that referenced this pull request May 18, 2026
@oferchen
docs(audits): bound io_uring bgid u16 namespace exhaustion (#2044) (#…
3ce5c3b 
…3894)

Document that buffer-group ids are u16 in io_uring (max 65 535 per
ring), audit current `BufferRing` lifecycle (kernel reclaims via
`IORING_UNREGISTER_PBUF_RING` on drop, but no in-process allocator
owns the namespace), sketch the long-running daemon worst case, and
propose a hard-capped slab allocator with telemetry and a typed
exhaustion error before #1936 / #1937 wire PBUF_RING through the
per-session ring.
oferchen added a commit that referenced this pull request May 18, 2026
@oferchen
docs: design per-session io_uring ring pool footprint controls (#1936) (
9b22e25 
#4014)

Adds the per-session ring pool design that focuses on reducing
per-process io_uring memory cost when many oc-rsync invocations run
concurrently. Surveys current ring construction, names the four
in-scope levers (lazy ring construction, adaptive registered-buffer
count, soft cap via CLI/env, probe-cache invariant), and sequences
them as independent PRs.
oferchen added a commit that referenced this pull request May 18, 2026
@oferchen
docs(audits): BGID lifecycle + exhaustion risk (#2293, #2294) (#4331)
aa6b64f 
Catalogues the allocation site (BgidAllocator::allocate at
crates/fast_io/src/io_uring/buffer_ring.rs:193) and the release site
(BufferRing::Drop at buffer_ring.rs:720, deallocate at :245).
Pins BgidExhausted definition (io_uring_common.rs:370) and the two
raise sites. Identifies the gap that BGE-3 and BGE-4 need to close:
no peak telemetry, unbounded free-list, no in-tree caller (production
PBUF wiring is still pending under #1936/#1937). Lays out the
free-list pool + Drop signal recycling plan for BGE-4 and the
churn / loom / recovery stress matrix for BGE-5.
oferchen added a commit that referenced this pull request May 18, 2026
@oferchen
docs(audits): BGID lifecycle + exhaustion risk (#2293, #2294) (#4331)
043bafb 
Catalogues the allocation site (BgidAllocator::allocate at
crates/fast_io/src/io_uring/buffer_ring.rs:193) and the release site
(BufferRing::Drop at buffer_ring.rs:720, deallocate at :245).
Pins BgidExhausted definition (io_uring_common.rs:370) and the two
raise sites. Identifies the gap that BGE-3 and BGE-4 need to close:
no peak telemetry, unbounded free-list, no in-tree caller (production
PBUF wiring is still pending under #1936/#1937). Lays out the
free-list pool + Drop signal recycling plan for BGE-4 and the
churn / loom / recovery stress matrix for BGE-5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@oferchen