Skip to content

Remove redundant must_use attributes in embedding API#2043

Merged
oferchen merged 1 commit into
masterfrom
fix-clippy-warnings-in-embedding-module
Nov 7, 2025
Merged

Remove redundant must_use attributes in embedding API#2043
oferchen merged 1 commit into
masterfrom
fix-clippy-warnings-in-embedding-module

Conversation

@oferchen
Copy link
Copy Markdown
Owner

@oferchen oferchen commented Nov 7, 2025

Summary

  • remove redundant #[must_use] attributes from the embedding run helpers that return Result
  • stop cloning fixed-size argument arrays in the embedding integration tests

Testing

  • cargo clippy --workspace --all-targets --all-features --no-deps -- -D warnings

Codex Task

@oferchen oferchen merged commit bee8c16 into master Nov 7, 2025
@oferchen oferchen deleted the fix-clippy-warnings-in-embedding-module branch November 7, 2025 20:27
@oferchen oferchen mentioned this pull request May 1, 2026
Merged
4 tasks
oferchen added a commit that referenced this pull request May 1, 2026
@oferchen
docs(fast_io): evaluate IORING_REGISTER_PBUF_RING for read paths (#2043…
d16ea19 
…) (#3504)

Evaluate provided-buffer rings (PBUF_RING, kernel 5.19+) against the
existing IORING_REGISTER_BUFFERS path. Survey current io_uring read
sites in fast_io, document the layered kernel-version fallback chain,
and recommend keeping IoUringReader on READ_FIXED while reserving
PBUF_RING for stream receive paths (IoUringSocketReader and a future
IoUringPipeReader). Document a Phase 1/2/3 plan: this audit, then
opcode-aware probing surfaced via --version, then actual PBUF_RING
usage gated on a benchmark.
oferchen added a commit that referenced this pull request May 5, 2026
@oferchen
docs(fast_io): evaluate IORING_REGISTER_PBUF_RING for read paths (#2043…
6b67295 
…) (#3504)

Evaluate provided-buffer rings (PBUF_RING, kernel 5.19+) against the
existing IORING_REGISTER_BUFFERS path. Survey current io_uring read
sites in fast_io, document the layered kernel-version fallback chain,
and recommend keeping IoUringReader on READ_FIXED while reserving
PBUF_RING for stream receive paths (IoUringSocketReader and a future
IoUringPipeReader). Document a Phase 1/2/3 plan: this audit, then
opcode-aware probing surfaced via --version, then actual PBUF_RING
usage gated on a benchmark.
This was referenced May 5, 2026
Merged
Merged
oferchen added a commit that referenced this pull request May 5, 2026
@oferchen
feat(fast_io): cache PBUF_RING probe and surface in --version
34ecbfd 
Adds a process-wide `OnceLock`-cached `pbuf_ring_supported()` probe for
`IORING_REGISTER_PBUF_RING` (Linux 5.19+), surfaces it on
`IoUringKernelInfo::pbuf_ring_supported`, and appends `pbuf_ring=yes/no`
to the `--version` reason string. The cross-platform stub mirrors the
same surface and always returns `false`. The fallback chain
(PBUF_RING -> classic provide-buffers -> standard read/write -> non-Linux
io_uring stub) is now documented at the module level on
`io_uring/buffer_ring.rs` and `io_uring/mod.rs`, and reflected in
`docs/audits/iouring-pbuf-ring.md` Phase 2 status.

Refs task #2043.
oferchen added a commit that referenced this pull request May 6, 2026
@oferchen
docs(design): io_uring submission-modes benchmark plan (#1626)
b8e35e0 
Plan benchmarking regular submit_and_wait vs SQPOLL vs std I/O across
small/large/mid file workloads, the CAP_SYS_NICE privilege matrix
including unprivileged container (#1624), and kernels 5.6 / 5.11 / 5.15
/ 6.0 / 6.6. Cross-references the session ring pool (#1408 / #1409),
PBUF_RING audit (#2043), and registered-buffer adaptive sizing (#2045).
oferchen added a commit that referenced this pull request May 6, 2026
@oferchen
docs(design): io_uring submission-modes benchmark plan (#1626) (#3718)
da465bf 
Plan benchmarking regular submit_and_wait vs SQPOLL vs std I/O across
small/large/mid file workloads, the CAP_SYS_NICE privilege matrix
including unprivileged container (#1624), and kernels 5.6 / 5.11 / 5.15
/ 6.0 / 6.6. Cross-references the session ring pool (#1408 / #1409),
PBUF_RING audit (#2043), and registered-buffer adaptive sizing (#2045).
oferchen added a commit that referenced this pull request May 6, 2026
@oferchen
feat(fast_io): cache PBUF_RING probe and surface in --version
9fbc31a 
Adds a process-wide `OnceLock`-cached `pbuf_ring_supported()` probe for
`IORING_REGISTER_PBUF_RING` (Linux 5.19+), surfaces it on
`IoUringKernelInfo::pbuf_ring_supported`, and appends `pbuf_ring=yes/no`
to the `--version` reason string. The cross-platform stub mirrors the
same surface and always returns `false`. The fallback chain
(PBUF_RING -> classic provide-buffers -> standard read/write -> non-Linux
io_uring stub) is now documented at the module level on
`io_uring/buffer_ring.rs` and `io_uring/mod.rs`, and reflected in
`docs/audits/iouring-pbuf-ring.md` Phase 2 status.

Refs task #2043.
oferchen added a commit that referenced this pull request May 6, 2026
@oferchen
feat(fast_io): cache PBUF_RING probe and surface in --version
dc34a3d 
Adds a process-wide `OnceLock`-cached `pbuf_ring_supported()` probe for
`IORING_REGISTER_PBUF_RING` (Linux 5.19+), surfaces it on
`IoUringKernelInfo::pbuf_ring_supported`, and appends `pbuf_ring=yes/no`
to the `--version` reason string. The cross-platform stub mirrors the
same surface and always returns `false`. The fallback chain
(PBUF_RING -> classic provide-buffers -> standard read/write -> non-Linux
io_uring stub) is now documented at the module level on
`io_uring/buffer_ring.rs` and `io_uring/mod.rs`, and reflected in
`docs/audits/iouring-pbuf-ring.md` Phase 2 status.

Refs task #2043.
oferchen added a commit that referenced this pull request May 6, 2026
@oferchen
feat(fast_io): cache PBUF_RING probe and surface in --version (#3635)
8e1cd07 
Adds a process-wide `OnceLock`-cached `pbuf_ring_supported()` probe for
`IORING_REGISTER_PBUF_RING` (Linux 5.19+), surfaces it on
`IoUringKernelInfo::pbuf_ring_supported`, and appends `pbuf_ring=yes/no`
to the `--version` reason string. The cross-platform stub mirrors the
same surface and always returns `false`. The fallback chain
(PBUF_RING -> classic provide-buffers -> standard read/write -> non-Linux
io_uring stub) is now documented at the module level on
`io_uring/buffer_ring.rs` and `io_uring/mod.rs`, and reflected in
`docs/audits/iouring-pbuf-ring.md` Phase 2 status.

Refs task #2043.
oferchen added a commit that referenced this pull request May 18, 2026
@oferchen
docs(design): io_uring submission-modes benchmark plan (#1626) (#3718)
378f9e1 
Plan benchmarking regular submit_and_wait vs SQPOLL vs std I/O across
small/large/mid file workloads, the CAP_SYS_NICE privilege matrix
including unprivileged container (#1624), and kernels 5.6 / 5.11 / 5.15
/ 6.0 / 6.6. Cross-references the session ring pool (#1408 / #1409),
PBUF_RING audit (#2043), and registered-buffer adaptive sizing (#2045).
oferchen added a commit that referenced this pull request May 18, 2026
@oferchen
feat(fast_io): cache PBUF_RING probe and surface in --version (#3635)
b585a64 
Adds a process-wide `OnceLock`-cached `pbuf_ring_supported()` probe for
`IORING_REGISTER_PBUF_RING` (Linux 5.19+), surfaces it on
`IoUringKernelInfo::pbuf_ring_supported`, and appends `pbuf_ring=yes/no`
to the `--version` reason string. The cross-platform stub mirrors the
same surface and always returns `false`. The fallback chain
(PBUF_RING -> classic provide-buffers -> standard read/write -> non-Linux
io_uring stub) is now documented at the module level on
`io_uring/buffer_ring.rs` and `io_uring/mod.rs`, and reflected in
`docs/audits/iouring-pbuf-ring.md` Phase 2 status.

Refs task #2043.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@oferchen