Fix ignore-times quick check comparison#2059
Merged
Merged
Conversation
This was referenced May 5, 2026
oferchen
added a commit
that referenced
this pull request
May 5, 2026
Add an integration test that drives DeltaSignatureIndex::build + DeltaGenerator::generate over basis/source pairs where almost no basis blocks recur in source. Pins today's pre-bithash baseline matching behaviour for the rolling-hash hot path so the planned prefilter work (#2059) can be benchmarked against a fixed accuracy reference. The matrix sweeps planted block counts K in {0, 1, 2}, basis sizes in {64 KB, 1 MB, 16 MB}, block sizes in {1024, 4096}, and strong checksum algorithms (MD5, XXH3-64). The 16 MB cases are gated behind #[ignore] so default cargo nextest runs only the smaller fixtures; stress-test CI matrices opt in via --run-ignored only.
oferchen
added a commit
that referenced
this pull request
May 5, 2026
* test(match): zsync sparse-match adversarial fixture Add an integration test that drives DeltaSignatureIndex::build + DeltaGenerator::generate over basis/source pairs where almost no basis blocks recur in source. Pins today's pre-bithash baseline matching behaviour for the rolling-hash hot path so the planned prefilter work (#2059) can be benchmarked against a fixed accuracy reference. The matrix sweeps planted block counts K in {0, 1, 2}, basis sizes in {64 KB, 1 MB, 16 MB}, block sizes in {1024, 4096}, and strong checksum algorithms (MD5, XXH3-64). The 16 MB cases are gated behind #[ignore] so default cargo nextest runs only the smaller fixtures; stress-test CI matrices opt in via --run-ignored only. * style: cargo fmt * fix(test): inline format args in sparse-match assert
This was referenced May 5, 2026
oferchen
added a commit
that referenced
this pull request
May 7, 2026
…#3933) Document the four wire-compatible zsync-inspired matching speedups (bithash prefilter #2059-2062, seq-match extend-run #2064-2066, matched-block pruning #2068-2070, compact-keys layout #2072-2073) with CHANGELOG snippets, a release notes block, an anti-spec forbidding wire-feature advertisement, and a placeholder for benchmark numbers pending #2081 and #2082.
7 tasks
oferchen
added a commit
that referenced
this pull request
May 16, 2026
Captures evidence that the cumulative zsync-inspired matching work (#2059-#2087) plus its three recent follow-up PRs (#4164 adversarial fixtures, #4166 arena allocator feasibility audit, #4169 zsync cleanup audit) has not regressed upstream rsync interoperability. Anchored on master commit 6a615aa where both the CI and Interop Validation workflows are green. Records the per-version matrix (3.0.9 / 3.1.3 / 3.4.1 / 3.4.2 native, plus protocols 28-32 against 3.4.2), the 71-scenario standalone list with the single pre-existing known failure, and the delta-stats parity proof (oc-rsync and upstream both report matched=91900) that the matching pipeline remains wire-equivalent.
oferchen
added a commit
that referenced
this pull request
May 16, 2026
…4171) Captures evidence that the cumulative zsync-inspired matching work (#2059-#2087) plus its three recent follow-up PRs (#4164 adversarial fixtures, #4166 arena allocator feasibility audit, #4169 zsync cleanup audit) has not regressed upstream rsync interoperability. Anchored on master commit 6a615aa where both the CI and Interop Validation workflows are green. Records the per-version matrix (3.0.9 / 3.1.3 / 3.4.1 / 3.4.2 native, plus protocols 28-32 against 3.4.2), the 71-scenario standalone list with the single pre-existing known failure, and the delta-stats parity proof (oc-rsync and upstream both report matched=91900) that the matching pipeline remains wire-equivalent.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
* test(match): zsync sparse-match adversarial fixture Add an integration test that drives DeltaSignatureIndex::build + DeltaGenerator::generate over basis/source pairs where almost no basis blocks recur in source. Pins today's pre-bithash baseline matching behaviour for the rolling-hash hot path so the planned prefilter work (#2059) can be benchmarked against a fixed accuracy reference. The matrix sweeps planted block counts K in {0, 1, 2}, basis sizes in {64 KB, 1 MB, 16 MB}, block sizes in {1024, 4096}, and strong checksum algorithms (MD5, XXH3-64). The 16 MB cases are gated behind #[ignore] so default cargo nextest runs only the smaller fixtures; stress-test CI matrices opt in via --run-ignored only. * style: cargo fmt * fix(test): inline format args in sparse-match assert
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…#3933) Document the four wire-compatible zsync-inspired matching speedups (bithash prefilter #2059-2062, seq-match extend-run #2064-2066, matched-block pruning #2068-2070, compact-keys layout #2072-2073) with CHANGELOG snippets, a release notes block, an anti-spec forbidding wire-feature advertisement, and a placeholder for benchmark numbers pending #2081 and #2082.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…4171) Captures evidence that the cumulative zsync-inspired matching work (#2059-#2087) plus its three recent follow-up PRs (#4164 adversarial fixtures, #4166 arena allocator feasibility audit, #4169 zsync cleanup audit) has not regressed upstream rsync interoperability. Anchored on master commit bfb940e where both the CI and Interop Validation workflows are green. Records the per-version matrix (3.0.9 / 3.1.3 / 3.4.1 / 3.4.2 native, plus protocols 28-32 against 3.4.2), the 71-scenario standalone list with the single pre-existing known failure, and the delta-stats parity proof (oc-rsync and upstream both report matched=91900) that the matching pipeline remains wire-equivalent.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…4171) Captures evidence that the cumulative zsync-inspired matching work (#2059-#2087) plus its three recent follow-up PRs (#4164 adversarial fixtures, #4166 arena allocator feasibility audit, #4169 zsync cleanup audit) has not regressed upstream rsync interoperability. Anchored on master commit 7329d95 where both the CI and Interop Validation workflows are green. Records the per-version matrix (3.0.9 / 3.1.3 / 3.4.1 / 3.4.2 native, plus protocols 28-32 against 3.4.2), the 71-scenario standalone list with the single pre-existing known failure, and the delta-stats parity proof (oc-rsync and upstream both report matched=91900) that the matching pipeline remains wire-equivalent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Codex Task