Skip to content

Normalize version banner tests to branding constants#2114

Merged
oferchen merged 1 commit into
masterfrom
implement-oc-rsync-branding-and-packaging-changes
Nov 9, 2025
Merged

Normalize version banner tests to branding constants#2114
oferchen merged 1 commit into
masterfrom
implement-oc-rsync-branding-and-packaging-changes

Conversation

@oferchen
Copy link
Copy Markdown
Owner

@oferchen oferchen commented Nov 9, 2025

Summary

  • replace hard-coded version banner strings in the core version metadata/report tests with branded program name constants
  • update doctests to import the branded constants so the documentation examples respect workspace branding metadata

Testing

  • cargo test -p core version::tests::metadata::version_metadata_renders_standard_banner

Codex Task

@oferchen oferchen merged commit 5e2221b into master Nov 9, 2025
@oferchen oferchen deleted the implement-oc-rsync-branding-and-packaging-changes branch November 9, 2025 11:12
This was referenced May 7, 2026
Merged
Merged
oferchen added a commit that referenced this pull request May 7, 2026
@oferchen
docs(audits): add RERR_* exit-code coverage matrix (#2114) (#3856)
badb717 
Map every upstream rsync 3.4.1 RERR_* symbol to oc-rsync's ExitCode enum,
flag emission gaps, and call out the top five missing or mismatched
mappings (RERR_SIGNAL1, RERR_LOG_FAILURE, RERR_MESSAGEIO, RERR_CRASHED,
RERR_MALLOC).
oferchen added a commit that referenced this pull request May 7, 2026
@oferchen
docs(audits): RERR_* exit-code full coverage matrix (#2114) (#3917)
f20e6e9 
Tabulate every upstream RERR_* code, the matching ExitCode variant,
production trigger sites, gaps, and the end-to-end tests needed in
tests/exit_codes.rs to reach full coverage.
oferchen added a commit that referenced this pull request May 13, 2026
@oferchen
feat(core): wire missing RERR exit codes (#2114)
0b4b21d 
Close three exit code gaps identified in the RERR audit:

- CommandRun(126): add explicit match arm in map_child_exit_status for
  shell exit 126, matching the existing 127/255 handling pattern.
- Unsupported(4): map io::ErrorKind::Unsupported to ExitCode::Unsupported
  in from_io_error and change apply_protocol_restrictions to use
  ErrorKind::Unsupported so protocol feature rejections (ACLs, xattrs,
  fuzzy below minimum version) produce exit code 4.
- MessageIo(13): change daemon log_file_error from FEATURE_UNAVAILABLE(1)
  to MessageIo(13) per upstream log.c:163.
oferchen added a commit that referenced this pull request May 13, 2026
@oferchen
feat(core): wire missing RERR exit codes (#2114)
73f381a 
Close three exit code gaps identified in the RERR audit:

- CommandRun(126): add explicit match arm in map_child_exit_status for
  shell exit 126, matching the existing 127/255 handling pattern.
- Unsupported(4): map io::ErrorKind::Unsupported to ExitCode::Unsupported
  in from_io_error and change apply_protocol_restrictions to use
  ErrorKind::Unsupported so protocol feature rejections (ACLs, xattrs,
  fuzzy below minimum version) produce exit code 4.
- MessageIo(13): change daemon log_file_error from FEATURE_UNAVAILABLE(1)
  to MessageIo(13) per upstream log.c:163.
oferchen added a commit that referenced this pull request May 13, 2026
@oferchen
feat(core): wire missing RERR exit codes (#2114)
2c9d51a 
Close three exit code gaps identified in the RERR audit:

- CommandRun(126): add explicit match arm in map_child_exit_status for
  shell exit 126, matching the existing 127/255 handling pattern.
- Unsupported(4): map io::ErrorKind::Unsupported to ExitCode::Unsupported
  in from_io_error and change apply_protocol_restrictions to use
  ErrorKind::Unsupported so protocol feature rejections (ACLs, xattrs,
  fuzzy below minimum version) produce exit code 4.
- MessageIo(13): change daemon log_file_error from FEATURE_UNAVAILABLE(1)
  to MessageIo(13) per upstream log.c:163.
oferchen added a commit that referenced this pull request May 13, 2026
@oferchen
Merge pull request #3962 from oferchen/feat/exit-code-gaps-2114
cc705a9 
feat(core): wire missing RERR exit codes (#2114)
@oferchen oferchen mentioned this pull request May 14, 2026
Merged
3 tasks
oferchen added a commit that referenced this pull request May 18, 2026
@oferchen
docs(audits): add RERR_* exit-code coverage matrix (#2114) (#3856)
1da6a84 
Map every upstream rsync 3.4.1 RERR_* symbol to oc-rsync's ExitCode enum,
flag emission gaps, and call out the top five missing or mismatched
mappings (RERR_SIGNAL1, RERR_LOG_FAILURE, RERR_MESSAGEIO, RERR_CRASHED,
RERR_MALLOC).
oferchen added a commit that referenced this pull request May 18, 2026
@oferchen
docs(audits): RERR_* exit-code full coverage matrix (#2114) (#3917)
f230452 
Tabulate every upstream RERR_* code, the matching ExitCode variant,
production trigger sites, gaps, and the end-to-end tests needed in
tests/exit_codes.rs to reach full coverage.
oferchen added a commit that referenced this pull request May 18, 2026
@oferchen
feat(core): wire missing RERR exit codes (#2114)
ba5567a 
Close three exit code gaps identified in the RERR audit:

- CommandRun(126): add explicit match arm in map_child_exit_status for
  shell exit 126, matching the existing 127/255 handling pattern.
- Unsupported(4): map io::ErrorKind::Unsupported to ExitCode::Unsupported
  in from_io_error and change apply_protocol_restrictions to use
  ErrorKind::Unsupported so protocol feature rejections (ACLs, xattrs,
  fuzzy below minimum version) produce exit code 4.
- MessageIo(13): change daemon log_file_error from FEATURE_UNAVAILABLE(1)
  to MessageIo(13) per upstream log.c:163.
oferchen added a commit that referenced this pull request May 18, 2026
@oferchen
Merge pull request #3962 from oferchen/feat/exit-code-gaps-2114
87a8b36 
feat(core): wire missing RERR exit codes (#2114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@oferchen