Document test prerequisites#2168
Merged
Merged
Conversation
4 tasks
oferchen
added a commit
that referenced
this pull request
May 14, 2026
…y) (#4055) * feat: server-side tolerance for unknown --info tokens Mirror upstream's parse_output_words() guard so the server side silently skips unknown info-flag names. A newer client can forward info tokens this build has not learned yet without breaking the transfer, while the client-side parser still rejects unknown tokens so typos surface at the source. upstream: options.c parse_output_words - the `!am_server` check at options.c:465 short-circuits the `Unknown --info item` exit. Refs #2168 * fix: gate unused apply() wrapper behind cfg(test) The apply() helper is only invoked from unit tests now that production code routes through apply_with_mode(). Clippy's dead-code lint flagged it under -D warnings. Gating it with #[cfg(test)] keeps tests compiling while satisfying the lib build. * fix: derive Debug on InfoFlagSettings for expect_err in tests * fix: replace err().expect() with expect_err() in test sites clippy::err_expect lint became active after deriving Debug on InfoFlagSettings; the lint requires the success type to implement Debug to suggest the simpler expect_err form. * fix: derive Debug on DebugFlagSettings for expect_err in tests * fix: convert remaining multi-line err().expect() to expect_err()
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…y) (#4055) * feat: server-side tolerance for unknown --info tokens Mirror upstream's parse_output_words() guard so the server side silently skips unknown info-flag names. A newer client can forward info tokens this build has not learned yet without breaking the transfer, while the client-side parser still rejects unknown tokens so typos surface at the source. upstream: options.c parse_output_words - the `!am_server` check at options.c:465 short-circuits the `Unknown --info item` exit. Refs #2168 * fix: gate unused apply() wrapper behind cfg(test) The apply() helper is only invoked from unit tests now that production code routes through apply_with_mode(). Clippy's dead-code lint flagged it under -D warnings. Gating it with #[cfg(test)] keeps tests compiling while satisfying the lib build. * fix: derive Debug on InfoFlagSettings for expect_err in tests * fix: replace err().expect() with expect_err() in test sites clippy::err_expect lint became active after deriving Debug on InfoFlagSettings; the lint requires the success type to implement Debug to suggest the simpler expect_err form. * fix: derive Debug on DebugFlagSettings for expect_err in tests * fix: convert remaining multi-line err().expect() to expect_err()
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…y) (#4055) * feat: server-side tolerance for unknown --info tokens Mirror upstream's parse_output_words() guard so the server side silently skips unknown info-flag names. A newer client can forward info tokens this build has not learned yet without breaking the transfer, while the client-side parser still rejects unknown tokens so typos surface at the source. upstream: options.c parse_output_words - the `!am_server` check at options.c:465 short-circuits the `Unknown --info item` exit. Refs #2168 * fix: gate unused apply() wrapper behind cfg(test) The apply() helper is only invoked from unit tests now that production code routes through apply_with_mode(). Clippy's dead-code lint flagged it under -D warnings. Gating it with #[cfg(test)] keeps tests compiling while satisfying the lib build. * fix: derive Debug on InfoFlagSettings for expect_err in tests * fix: replace err().expect() with expect_err() in test sites clippy::err_expect lint became active after deriving Debug on InfoFlagSettings; the lint requires the success type to implement Debug to suggest the simpler expect_err form. * fix: derive Debug on DebugFlagSettings for expect_err in tests * fix: convert remaining multi-line err().expect() to expect_err()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Codex Task