Align xtask test command with CI targets#2217
Merged
Merged
Conversation
5 tasks
oferchen
added a commit
that referenced
this pull request
May 15, 2026
…y) (#4095) Adds the upstream rsync 3.4.2 --compress-threads / --zt long option to oc-rsync. The flag accepts integers 0..=64; 0 (the default) lets zstd choose its own worker count. Negative values, non-numeric input, and out-of-range positive integers are rejected with a user-facing error. The value is plumbed through ParsedArgs -> drive options -> ClientConfigBuilder -> ClientConfig but is not yet forwarded to the zstd codec. The zstd ZSTD_c_nbWorkers wiring will land in a follow-up. Upstream reference (rsync-3.4.2/options.c): 89: int do_compression_threads = 0; /*n = 0 use rsync thread, n >= 1 spawn n threads for compression */ 760: {"compress-threads", 0, POPT_ARG_INT, &do_compression_threads, 0, 0, 0 }, 761: {"zt", 0, POPT_ARG_INT, &do_compression_threads, 0, 0, 0 }, 2016-2017: if (do_compression_threads < 0) do_compression_threads = 0; Refs #2238, parent #2217.
5 tasks
oferchen
added a commit
that referenced
this pull request
May 15, 2026
….2 parity) (#4100) * feat: wire --compress-threads=N through to zstd ZSTD_c_nbWorkers Plumb the value parsed in #4095 into the actual zstd encoder via `ZSTD_c_nbWorkers`, matching upstream `token.c:701` so a non-zero `--compress-threads=N` engages real worker threads instead of being silently dropped. - `compress::zstd::CountingZstdEncoder` gains `new_with_workers` / `with_sink_workers` constructors and a `SUPPORTS_MULTITHREAD` const. - `engine::ActiveCompressor::new_with_workers` and `transfer::CompressedWriter::with_workers` thread the value end to end. `LocalCopyOptions` gains `compression_threads` and is populated from `ClientConfig::compression_threads` in `apply_compression`. - Multithreaded zstd lives behind a `zstdmt` Cargo feature on the `compress` crate (off by default to avoid a forced C build cost). Requesting workers without the feature returns `Unsupported` so callers can fall back to single-threaded compression instead of silently discarding the user's request. upstream: options.c:89 do_compression_threads, token.c:701. Refs #2239, #2217. * style: apply rustfmt to zstd worker wiring * fix(compress): avoid Result::unwrap_err since encoder lacks Debug * fix(engine): wire compression_threads through options builder + Debug-safe unwrap * fix(engine): gate unused ActiveCompressor::new behind #[cfg(test)] * fix(transfer): avoid expect_err on CompressedWriter lacking Debug
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…y) (#4095) Adds the upstream rsync 3.4.2 --compress-threads / --zt long option to oc-rsync. The flag accepts integers 0..=64; 0 (the default) lets zstd choose its own worker count. Negative values, non-numeric input, and out-of-range positive integers are rejected with a user-facing error. The value is plumbed through ParsedArgs -> drive options -> ClientConfigBuilder -> ClientConfig but is not yet forwarded to the zstd codec. The zstd ZSTD_c_nbWorkers wiring will land in a follow-up. Upstream reference (rsync-3.4.2/options.c): 89: int do_compression_threads = 0; /*n = 0 use rsync thread, n >= 1 spawn n threads for compression */ 760: {"compress-threads", 0, POPT_ARG_INT, &do_compression_threads, 0, 0, 0 }, 761: {"zt", 0, POPT_ARG_INT, &do_compression_threads, 0, 0, 0 }, 2016-2017: if (do_compression_threads < 0) do_compression_threads = 0; Refs #2238, parent #2217.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
….2 parity) (#4100) * feat: wire --compress-threads=N through to zstd ZSTD_c_nbWorkers Plumb the value parsed in #4095 into the actual zstd encoder via `ZSTD_c_nbWorkers`, matching upstream `token.c:701` so a non-zero `--compress-threads=N` engages real worker threads instead of being silently dropped. - `compress::zstd::CountingZstdEncoder` gains `new_with_workers` / `with_sink_workers` constructors and a `SUPPORTS_MULTITHREAD` const. - `engine::ActiveCompressor::new_with_workers` and `transfer::CompressedWriter::with_workers` thread the value end to end. `LocalCopyOptions` gains `compression_threads` and is populated from `ClientConfig::compression_threads` in `apply_compression`. - Multithreaded zstd lives behind a `zstdmt` Cargo feature on the `compress` crate (off by default to avoid a forced C build cost). Requesting workers without the feature returns `Unsupported` so callers can fall back to single-threaded compression instead of silently discarding the user's request. upstream: options.c:89 do_compression_threads, token.c:701. Refs #2239, #2217. * style: apply rustfmt to zstd worker wiring * fix(compress): avoid Result::unwrap_err since encoder lacks Debug * fix(engine): wire compression_threads through options builder + Debug-safe unwrap * fix(engine): gate unused ActiveCompressor::new behind #[cfg(test)] * fix(transfer): avoid expect_err on CompressedWriter lacking Debug
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…y) (#4095) Adds the upstream rsync 3.4.2 --compress-threads / --zt long option to oc-rsync. The flag accepts integers 0..=64; 0 (the default) lets zstd choose its own worker count. Negative values, non-numeric input, and out-of-range positive integers are rejected with a user-facing error. The value is plumbed through ParsedArgs -> drive options -> ClientConfigBuilder -> ClientConfig but is not yet forwarded to the zstd codec. The zstd ZSTD_c_nbWorkers wiring will land in a follow-up. Upstream reference (rsync-3.4.2/options.c): 89: int do_compression_threads = 0; /*n = 0 use rsync thread, n >= 1 spawn n threads for compression */ 760: {"compress-threads", 0, POPT_ARG_INT, &do_compression_threads, 0, 0, 0 }, 761: {"zt", 0, POPT_ARG_INT, &do_compression_threads, 0, 0, 0 }, 2016-2017: if (do_compression_threads < 0) do_compression_threads = 0; Refs #2238, parent #2217.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
….2 parity) (#4100) * feat: wire --compress-threads=N through to zstd ZSTD_c_nbWorkers Plumb the value parsed in #4095 into the actual zstd encoder via `ZSTD_c_nbWorkers`, matching upstream `token.c:701` so a non-zero `--compress-threads=N` engages real worker threads instead of being silently dropped. - `compress::zstd::CountingZstdEncoder` gains `new_with_workers` / `with_sink_workers` constructors and a `SUPPORTS_MULTITHREAD` const. - `engine::ActiveCompressor::new_with_workers` and `transfer::CompressedWriter::with_workers` thread the value end to end. `LocalCopyOptions` gains `compression_threads` and is populated from `ClientConfig::compression_threads` in `apply_compression`. - Multithreaded zstd lives behind a `zstdmt` Cargo feature on the `compress` crate (off by default to avoid a forced C build cost). Requesting workers without the feature returns `Unsupported` so callers can fall back to single-threaded compression instead of silently discarding the user's request. upstream: options.c:89 do_compression_threads, token.c:701. Refs #2239, #2217. * style: apply rustfmt to zstd worker wiring * fix(compress): avoid Result::unwrap_err since encoder lacks Debug * fix(engine): wire compression_threads through options builder + Debug-safe unwrap * fix(engine): gate unused ActiveCompressor::new behind #[cfg(test)] * fix(transfer): avoid expect_err on CompressedWriter lacking Debug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo nextestwith--all-targetsso it mirrors CI coverageTesting
Codex Task