Optimize protocol negotiation bitmap handling#296
Merged
Conversation
oferchen
added a commit
that referenced
this pull request
Feb 22, 2026
Add io_error accumulator to MultiplexReader that OR's incoming MSG_IO_ERROR payloads (upstream io.c:1521-1528). Previously these messages were silently discarded in the catch-all arm. Add take_io_error() to both MultiplexReader and ServerReader for the receiver to retrieve and forward accumulated I/O error flags.
6 tasks
oferchen
added a commit
that referenced
this pull request
Feb 22, 2026
Add io_error accumulator to MultiplexReader that OR's incoming MSG_IO_ERROR payloads (upstream io.c:1521-1528). Previously these messages were silently discarded in the catch-all arm. Add take_io_error() to both MultiplexReader and ServerReader for the receiver to retrieve and forward accumulated I/O error flags.
oferchen
added a commit
that referenced
this pull request
May 1, 2026
Add io_error accumulator to MultiplexReader that OR's incoming MSG_IO_ERROR payloads (upstream io.c:1521-1528). Previously these messages were silently discarded in the catch-all arm. Add take_io_error() to both MultiplexReader and ServerReader for the receiver to retrieve and forward accumulated I/O error flags.
oferchen
added a commit
that referenced
this pull request
May 5, 2026
Add io_error accumulator to MultiplexReader that OR's incoming MSG_IO_ERROR payloads (upstream io.c:1521-1528). Previously these messages were silently discarded in the catch-all arm. Add take_io_error() to both MultiplexReader and ServerReader for the receiver to retrieve and forward accumulated I/O error flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
select_highest_mutualwith a bitmap instead of a boolean array to cut per-call allocationsu64::BITSwhile still reconstructing the diagnostic peer list in orderTesting
https://chatgpt.com/codex/tasks/task_e_68f15b9998f8832385862de6e68034a0