feat: add Windows daemon privilege dropping and name resolution (phase 2)#3089
Merged
feat: add Windows daemon privilege dropping and name resolution (phase 2)#3089
Conversation
…e 2) Add Win32 API-based name resolution (LookupAccountNameW, NetUserEnum), group member expansion (NetLocalGroupGetMembers), and name converter integration for Windows daemon mode. Platform crate exposes safe APIs; daemon crate stays 100% safe Rust.
oferchen
force-pushed
the
feature/windows-daemon-phase2
branch
from
1e490b7 to
80377c1
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rid_to_account_name()andlookup_account_info()to platform crate for Windows RID/account name resolution viaNetUserEnumandLookupAccountNameWNetLocalGroupGetMembersin platformgroup.rsWindowsNameConverterimplementingNameConverterCallbackstrait using Win32 APIs directly (no subprocess needed since Windows doesn't use chroot)Closes #2772 (phase 2)
Test plan
None- verified by unit tests