Skip to content

docs(cli): audit --iconv feature design and wire protocol surface#3495

Merged
oferchen merged 1 commit into
masterfrom
docs/iconv-feature-design
May 1, 2026
Merged

docs(cli): audit --iconv feature design and wire protocol surface#3495
oferchen merged 1 commit into
masterfrom
docs/iconv-feature-design

Conversation

@oferchen
Copy link
Copy Markdown
Owner

@oferchen oferchen commented May 1, 2026

Summary

  • Documents upstream rsync 3.4.1's --iconv charset-translation behavior at the wire level, citing the relevant C source via docs/audits/iconv-pipeline.md (upstream tarball is not unpacked locally in this checkout).
  • Inventories the current oc-rsync surface (already-wired CLI parsing, IconvSetting, protocol::iconv, FilenameConverter, capability flag) versus what is missing (the IconvSetting -> FilenameConverter adapter, symlink/files-from/secluded-args hooks, conditional 's' advertisement).
  • Recommends staying on encoding_rs over system iconv (no unsafe, cross-platform, sufficient charset coverage) and proposes a feature-gated implementation plan plus an interop test scenario list.

Complements docs/audits/iconv-pipeline.md (gap inventory). No code changes.

Test plan

  • Docs-only change; CI fmt/clippy/build matrix should pass without code edits.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label May 1, 2026
@oferchen oferchen merged commit c0f0d55 into master May 1, 2026
12 checks passed
@oferchen oferchen deleted the docs/iconv-feature-design branch May 1, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant