test(interop): add --iconv UTF-8/LATIN1 round-trip vs upstream 3.4.1 (#1916)#3498
Merged
Conversation
…1916) Adds a bidirectional daemon-mode interop scenario that exercises --iconv=UTF-8,ISO-8859-1 between oc-rsync and upstream rsync 3.4.1. The test creates a deterministic source tree with UTF-8 filenames whose code points all fit in Latin-1 (café.txt, über.txt, ångström.txt) plus an ASCII baseline, then drives two transfers: 1. upstream client -> oc-rsync daemon (charset = ISO-8859-1) 2. oc-rsync client -> upstream daemon (charset = ISO-8859-1) Each transfer is verified by re-reading the destination filenames and comparing content byte-for-byte against the source. Daemon-mode iconv negotiation in oc-rsync is still incomplete: the `charset =` directive is parsed (crates/daemon/.../module_directives.rs) but never threaded into the iconv runtime setup. Findings 1-3 of the audit (symlink target transcoding, --files-from forwarding, --secluded-args/--protect-args transcoding) also remain open. The scenario is therefore added to KNOWN_FAILURES and DASHBOARD_ENTRIES so CI tracks the gap without blocking, and check_known_failures.sh gets a matching reproducer so the dashboard can rerun it. References: upstream: options.c:recv_iconv_settings, flist.c:1579-1603, flist.c:738-754 oc-rsync: docs/audits/iconv-pipeline.md Touched files: - tools/ci/run_interop.sh: new test_iconv_upstream_interop function, added "iconv-upstream" to standalone test_names/test_funcs arrays, port-injection case branch. - tools/ci/known_failures.conf: KNOWN_FAILURES + DASHBOARD_ENTRIES entry. - tools/ci/check_known_failures.sh: dashboard reproducer dispatch case.
oferchen
added a commit
that referenced
this pull request
May 5, 2026
…1916) (#3498) Adds a bidirectional daemon-mode interop scenario that exercises --iconv=UTF-8,ISO-8859-1 between oc-rsync and upstream rsync 3.4.1. The test creates a deterministic source tree with UTF-8 filenames whose code points all fit in Latin-1 (café.txt, über.txt, ångström.txt) plus an ASCII baseline, then drives two transfers: 1. upstream client -> oc-rsync daemon (charset = ISO-8859-1) 2. oc-rsync client -> upstream daemon (charset = ISO-8859-1) Each transfer is verified by re-reading the destination filenames and comparing content byte-for-byte against the source. Daemon-mode iconv negotiation in oc-rsync is still incomplete: the `charset =` directive is parsed (crates/daemon/.../module_directives.rs) but never threaded into the iconv runtime setup. Findings 1-3 of the audit (symlink target transcoding, --files-from forwarding, --secluded-args/--protect-args transcoding) also remain open. The scenario is therefore added to KNOWN_FAILURES and DASHBOARD_ENTRIES so CI tracks the gap without blocking, and check_known_failures.sh gets a matching reproducer so the dashboard can rerun it. References: upstream: options.c:recv_iconv_settings, flist.c:1579-1603, flist.c:738-754 oc-rsync: docs/audits/iconv-pipeline.md Touched files: - tools/ci/run_interop.sh: new test_iconv_upstream_interop function, added "iconv-upstream" to standalone test_names/test_funcs arrays, port-injection case branch. - tools/ci/known_failures.conf: KNOWN_FAILURES + DASHBOARD_ENTRIES entry. - tools/ci/check_known_failures.sh: dashboard reproducer dispatch case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_iconv_upstream_interopto the standalone interop matrix intools/ci/run_interop.sh. It exercises--iconv=UTF-8,ISO-8859-1in both directions between oc-rsync and upstream rsync 3.4.1 via daemon transport, with a deterministic UTF-8 fixture (café.txt,über.txt,ångström.txt, plus an ASCII baseline) whose code points all fit in Latin-1.docs/audits/iconv-pipeline.md(Findings 1-5) plus PR feat: bridge IconvSetting to FilenameConverter #3458's bridge fix the SSH/local path, but daemon-mode iconv (thecharset =directive) is not yet wired to the iconv runtime, so this test surfaces the remaining work without blocking CI.tools/ci/check_known_failures.shso the tracking dashboard can rerun the scenario as the gap is closed.What changed
tools/ci/run_interop.sh: newtest_iconv_upstream_interopfunction (after the existingtest_iconvat line 3092). Wired into the standalone matrix at thetest_names,test_funcs, and port-injectioncasebranches.tools/ci/known_failures.conf: new"standalone:iconv-upstream"entry inKNOWN_FAILURESand a correspondingDASHBOARD_ENTRIESrow referencing#1916and the audit doc.tools/ci/check_known_failures.sh: newiconv-upstream)dispatch case that drives a minimal upstream-client -> oc-rsync-daemon push.Test plan
tools/ci/run_interop.sh. The new scenario should appear under[standalone] iconv-upstreamand be reported asSKIP (known limitation)until the daemon iconv plumbing lands.KNOWN_FAILURESentry; the test should then reportPASSfor both directions.References
docs/audits/iconv-pipeline.mdfeat: bridge IconvSetting to FilenameConverter)options.c::recv_iconv_settings,flist.c:1579-1603(sender),flist.c:738-754(receiver)