docs(daemon): tcpdump audit of pull-direction filter wire (#1697)#3503
Merged
Conversation
Document that daemon-side filter rules (filter/exclude/include directives in oc-rsyncd.conf) are never transmitted on the wire during a pull, in both upstream rsync 3.4.1 and oc-rsync. Cite upstream clientserver.c:874-893 (rsync_module loads daemon_filter_list) and exclude.c:1589/1645/1658/1661 (send_rules walks &filter_list, never &daemon_filter_list). Cross-reference oc-rsync sources at crates/protocol/src/filters/wire.rs, crates/transfer/src/receiver/transfer.rs, and crates/daemon/src/daemon/sections/module_access/helpers.rs. Provide an operator-facing tcpdump reproduction recipe with decoded bytes for the 4-byte LE filter-list zero terminator. Note an unrelated comment discrepancy in tools/ci/known_failures.conf (rsync 3.0.9 advertises PROTOCOL_VERSION 30, not 28) for future cleanup.
github-actions
Bot
added
the
documentation
oferchen
added a commit
that referenced
this pull request
May 5, 2026
) Document that daemon-side filter rules (filter/exclude/include directives in oc-rsyncd.conf) are never transmitted on the wire during a pull, in both upstream rsync 3.4.1 and oc-rsync. Cite upstream clientserver.c:874-893 (rsync_module loads daemon_filter_list) and exclude.c:1589/1645/1658/1661 (send_rules walks &filter_list, never &daemon_filter_list). Cross-reference oc-rsync sources at crates/protocol/src/filters/wire.rs, crates/transfer/src/receiver/transfer.rs, and crates/daemon/src/daemon/sections/module_access/helpers.rs. Provide an operator-facing tcpdump reproduction recipe with decoded bytes for the 4-byte LE filter-list zero terminator. Note an unrelated comment discrepancy in tools/ci/known_failures.conf (rsync 3.0.9 advertises PROTOCOL_VERSION 30, not 28) for future cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/audits/tcpdump-daemon-filter-pull.mdto document, with citations to both upstream rsync 3.4.1 (clientserver.c:rsync_module,exclude.c:send_filter_list/send_rules) and oc-rsync sources (crates/protocol/src/filters/wire.rs,crates/transfer/src/receiver/transfer.rs,crates/daemon/src/daemon/sections/module_access/helpers.rs:build_daemon_filter_rules), that daemon-configured filter rules are never transmitted on the wire during a pull.oc-rsyncd.confsnippet, client command,tcp portfilter expression, decoded bytes for the 4-byte LE filter-list zero terminator) so operators can verify the property locally.tools/ci/known_failures.conf:81(rsync 3.0.9 actually advertisesPROTOCOL_VERSION 30, not 28) for future cleanup; this audit does not modify it.Closes #1697.
Test plan
docs(daemon):prefix and applies thedocumentationlabel.