docs(iconv): audit IconvSetting parse-path dead-end (#1909)#3514
Merged
Conversation
1 task
oferchen
added a commit
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
docs/audits/iconv-parse-deadend.md: a narrow trace of the--iconvargument from clap entry throughIconvSetting,ClientConfigBuilder,ClientConfig, and out to its consumers,identifying the residual dead-end after PR #3458.
The dead-end on the local-copy path is at
crates/core/src/client/run/mod.rs:275(build_local_copy_options(&config, filter_program)):the builder never reads
config.iconv(), andLocalCopyOptionsexposes no setter for an
Option<FilenameConverter>. Filter-rulematching has the same gap at
crates/core/src/client/run/mod.rs:274(compile_filter_program)and the
FilterChain::new(filter_set)call sites.Complements the existing
docs/audits/iconv-inert.md, which waswritten before PR #3458 wired the SSH/daemon bridge and surveys the
full pipeline rather than the parse path.
Guarantees
docs/audits/, no code or otherdoc changes.
path:linefor every step of the parsepath and every consumer site.
docs/audits/style: tracking issue, scope, evidencewith
path:linecitations, upstream cross-reference, summary.Test plan
docs/audits/iconv-parse-deadend.md.