docs(windows): audit backslash-leak in wire-encoded filenames (#1939)#3515
Merged
Conversation
Document the High-severity backslash-leak finding with reproduction steps and the remediation plan referencing task #1905. Refines the parent audit #1842 (windows-path-normalization.md) with a focused finding-level write-up: code paths, reproduction commands (daemon and batch capture), upstream comparison via Cygwin, the path_bytes_to_wire helper plan, regression-test obligations, and the Windows-sender -> Linux-receiver CI matrix entry.
github-actions
Bot
added
the
documentation
oferchen
added a commit
that referenced
this pull request
May 5, 2026
…#3515) Document the High-severity backslash-leak finding with reproduction steps and the remediation plan referencing task #1905. Refines the parent audit #1842 (windows-path-normalization.md) with a focused finding-level write-up: code paths, reproduction commands (daemon and batch capture), upstream comparison via Cygwin, the path_bytes_to_wire helper plan, regression-test obligations, and the Windows-sender -> Linux-receiver CI matrix entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\\(0x5C) bytes inside wire-encoded filenames where the rsync wire contract requires/, causing silent on-disk corruption on POSIX peers.crate/file.rs:linecitations and concrete reproduction steps using--write-batch=capture against both oc-rsync onwindows-msvcand upstream Cygwin rsync on the same host.path_bytes_to_wire(&Path) -> Cow<'_, [u8]>helper applied at four sites inprotocol::flistandtransfer::generator::file_list, paired with regression tests and a Windows-sender -> Linux-receiver CI matrix entry.Replaces the previous content of
docs/audits/windows-path.md(which was an interim verification note for #1905) with the full audit document required by tracker #1939. References parent audit #1842, fix tracker #1905, and the related Windows workstream entries (#1866, #1867, #1869, #1900).Test plan