fix(ci): escape charset backticks in known_failures.conf#3532
Merged
Conversation
Bash interprets backticks inside double-quoted strings as command substitution. Line 138 of tools/ci/known_failures.conf wrapped the word `charset` in backticks inside a DASHBOARD_ENTRIES entry, so sourcing the file ran `charset` as a command and aborted the script with exit 127, breaking the required `interop / interop with upstream rsync` CI check on master and every downstream PR. Replace the backticks with single quotes; the comment on the preceding line is unaffected because backticks inside `#` comments are inert.
oferchen
added a commit
that referenced
this pull request
May 5, 2026
Bash interprets backticks inside double-quoted strings as command substitution. Line 138 of tools/ci/known_failures.conf wrapped the word `charset` in backticks inside a DASHBOARD_ENTRIES entry, so sourcing the file ran `charset` as a command and aborted the script with exit 127, breaking the required `interop / interop with upstream rsync` CI check on master and every downstream PR. Replace the backticks with single quotes; the comment on the preceding line is unaffected because backticks inside `#` comments are inert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`charset`with'charset'inside the iconv-upstreamDASHBOARD_ENTRIESdescription string intools/ci/known_failures.conf.charsetas a command and exited 127, breaking the requiredinterop / interop with upstream rsyncCI check on master and on every open PR that inherited the failure.# daemon-mode iconv: \charset =` directive parsed but not wired to iconv runtimecomment is unaffected because backticks inside#` comments are inert.The unwired
charsetdirective itself is tracked in #1917 (daemon-sideiconv/charsetnot yet threaded into the iconv runtime); this PR is purely a CI hygiene fix.Test plan
bash -c 'source tools/ci/known_failures.conf && echo OK: \${#KNOWN_FAILURES[@]} known + \${#DASHBOARD_ENTRIES[@]} dashboard entries'returnsOK: 3 known + 8 dashboard entries(wasline 161: charset: command not found).interop / interop with upstream rsyncCI check passes on this PR.