Skip to content

docs(audits): eliminate-path matrix for tools/ci/known_failures.conf#3535

Merged
oferchen merged 1 commit into
masterfrom
docs/audits-known-failures-eliminate
May 1, 2026
Merged

docs(audits): eliminate-path matrix for tools/ci/known_failures.conf#3535
oferchen merged 1 commit into
masterfrom
docs/audits-known-failures-eliminate

Conversation

@oferchen
Copy link
Copy Markdown
Owner

@oferchen oferchen commented May 1, 2026

Summary

  • Adds docs/audits/known-failures-eliminate.md mapping every entry in tools/ci/known_failures.conf to a concrete eliminate path (fix in oc-rsync, permanent upstream bug, or permanent protocol-version-locked).
  • Cites upstream rsync 3.4.1 source (compat.c:655-668 for ACL/xattr/vstring gates, exclude.c:1530 for filter legal_len, token.c:608 for the upstream batch inflate bug) and existing tracking issues (Accelerate rolling checksum with SIMD fast paths #1916, Fix missing core imports in daemon tests #1685) plus the iconv/zstd/protocol companion audits.
  • Beta-readiness criterion Add coverage for duplicate protocol offers in negotiation #3 work-plan: 2 fixable entries (standalone:iconv-upstream daemon plumbing, standalone:delta-stats daemon-mode delta engine), 6 permanent (1 upstream bug + 5 protocol-version-locked at proto < 29/30).
  • Documentation only. Does not touch tools/ci/known_failures.conf, any crate, or any script.

Test plan

  • Markdown lint passes via repo conventions (no broken relative links to iconv-pipeline.md, zstd-batch-compatibility.md, protocol-28-32-interop-matrix.md, etc.).
  • CI fmt+clippy passes (no Rust changes; cargo fmt --all was run for hygiene).
  • Reviewer confirms each conf entry has a section in the audit and the punch-list table matches.

Maps each entry in the unconditional KNOWN_FAILURES array and each
conditional rule in is_known_failure_from_conf() to a concrete
eliminate path: fix in oc-rsync, permanent upstream bug, or permanent
protocol-version-locked. Cites upstream rsync 3.4.1 source (compat.c,
exclude.c, token.c) and existing tracking issues (#1916, #1685,
companion iconv/zstd/protocol audits) so beta-readiness criterion #3
has an explicit work-plan.

Two entries are fixable (standalone:iconv-upstream daemon plumbing and
standalone:delta-stats daemon-mode delta engine); six are permanent
(one upstream bug, five protocol-version-locked at proto < 29 or 30).
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label May 1, 2026
@oferchen oferchen marked this pull request as ready for review May 1, 2026 22:20
@oferchen oferchen merged commit 43f5761 into master May 1, 2026
12 checks passed
@oferchen oferchen deleted the docs/audits-known-failures-eliminate branch May 2, 2026 03:49
oferchen added a commit that referenced this pull request May 5, 2026
…3535)

Maps each entry in the unconditional KNOWN_FAILURES array and each
conditional rule in is_known_failure_from_conf() to a concrete
eliminate path: fix in oc-rsync, permanent upstream bug, or permanent
protocol-version-locked. Cites upstream rsync 3.4.1 source (compat.c,
exclude.c, token.c) and existing tracking issues (#1916, #1685,
companion iconv/zstd/protocol audits) so beta-readiness criterion #3
has an explicit work-plan.

Two entries are fixable (standalone:iconv-upstream daemon plumbing and
standalone:delta-stats daemon-mode delta engine); six are permanent
(one upstream bug, five protocol-version-locked at proto < 29 or 30).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant