fix(metadata): add Win32_System_SystemServices feature for ACL build (#1866)#3549
Merged
Merged
Conversation
…1866) PR #3544 moved the ACCESS_ALLOWED_ACE_TYPE import to windows::Win32::System::SystemServices to match windows-rs 0.62, but did not add the corresponding Cargo feature to Cargo.toml. This left the import unresolved on Windows targets: error[E0432]: unresolved import `windows::Win32::System::SystemServices` --> crates/metadata/src/acl_windows.rs:67:30 | 67 | use windows::Win32::System::SystemServices::ACCESS_ALLOWED_ACE_TYPE; | ^^^^^^^^^^^^^^ could not find `SystemServices` in `System` | = note: the item is gated behind the `Win32_System_SystemServices` feature Add the missing feature to the windows-rs dependency declaration so the ACL code compiles on all Windows toolchains (stable/beta/nightly/GNU). Unblocks: master CI (Windows stable required check), all 11 open PRs.
oferchen
added a commit
that referenced
this pull request
May 5, 2026
…-feature fix(metadata): add Win32_System_SystemServices feature for ACL build (#1866)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Win32_System_SystemServicesfeature flag to thewindows-rsdependency incrates/metadata/Cargo.tomlso theACCESS_ALLOWED_ACE_TYPEimport resolves on all Windows toolchains.Why
windows-rs 0.62 gates
ACCESS_ALLOWED_ACE_TYPEbehind theWin32_System_SystemServicesCargo feature:The import at
crates/metadata/src/acl_windows.rs:67therefore fails to resolve:This blocks Windows (stable), Windows (beta), Windows (nightly), and Windows GNU cross-check on master.
Test plan
cargo clippy --workspace --all-targets --all-featuressucceeds on WindowsRefs #1866. Hotfix on top of #3544.