Skip to content

fix(metadata): add Win32_System_SystemServices feature for ACL build (#1866)#3549

Merged
oferchen merged 1 commit into
masterfrom
fix/windows-acl-systemservices-feature
May 2, 2026
Merged

fix(metadata): add Win32_System_SystemServices feature for ACL build (#1866)#3549
oferchen merged 1 commit into
masterfrom
fix/windows-acl-systemservices-feature

Conversation

@oferchen
Copy link
Copy Markdown
Owner

@oferchen oferchen commented May 2, 2026

Summary

  • Adds the Win32_System_SystemServices feature flag to the windows-rs dependency in crates/metadata/Cargo.toml so the ACCESS_ALLOWED_ACE_TYPE import resolves on all Windows toolchains.
  • Hotfix for master: PR fix(metadata): import ACCESS_ALLOWED_ACE_TYPE from SystemServices (#1866) #3544 fixed the import path to match windows-rs 0.62, but did not add the Cargo feature gate. Master CI has been red since that merge — Windows (stable) required check fails on every PR.

Why

windows-rs 0.62 gates ACCESS_ALLOWED_ACE_TYPE behind the Win32_System_SystemServices Cargo feature:

note: the item is gated behind the `Win32_System_SystemServices` feature
135 | #[cfg(feature = "Win32_System_SystemServices")]
136 | pub mod SystemServices;

The import at crates/metadata/src/acl_windows.rs:67 therefore fails to resolve:

error[E0432]: unresolved import `windows::Win32::System::SystemServices`
 --> crates/metadata/src/acl_windows.rs:67:30
  |
69 | use windows::Win32::System::SystemServices::ACCESS_ALLOWED_ACE_TYPE;
  |                              ^^^^^^^^^^^^^^ could not find `SystemServices` in `System`

This blocks Windows (stable), Windows (beta), Windows (nightly), and Windows GNU cross-check on master.

Test plan

  • CI: Windows (stable) green
  • CI: Windows (beta) green
  • CI: Windows (nightly) green
  • CI: Windows GNU cross-check green
  • Confirms cargo clippy --workspace --all-targets --all-features succeeds on Windows
  • Unblocks the 11 open PRs that were red purely from this master regression

Refs #1866. Hotfix on top of #3544.

…1866)

PR #3544 moved the ACCESS_ALLOWED_ACE_TYPE import to
windows::Win32::System::SystemServices to match windows-rs 0.62, but did
not add the corresponding Cargo feature to Cargo.toml. This left the
import unresolved on Windows targets:

  error[E0432]: unresolved import `windows::Win32::System::SystemServices`
   --> crates/metadata/src/acl_windows.rs:67:30
    |
  67 | use windows::Win32::System::SystemServices::ACCESS_ALLOWED_ACE_TYPE;
    |                              ^^^^^^^^^^^^^^ could not find `SystemServices` in `System`
    |
    = note: the item is gated behind the `Win32_System_SystemServices` feature

Add the missing feature to the windows-rs dependency declaration so the
ACL code compiles on all Windows toolchains (stable/beta/nightly/GNU).

Unblocks: master CI (Windows stable required check), all 11 open PRs.
@github-actions github-actions Bot added the bug Something isn't working label May 2, 2026
@oferchen oferchen merged commit 0f148a8 into master May 2, 2026
39 checks passed
@oferchen oferchen deleted the fix/windows-acl-systemservices-feature branch May 2, 2026 03:49
oferchen added a commit that referenced this pull request May 5, 2026
…-feature

fix(metadata): add Win32_System_SystemServices feature for ACL build (#1866)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant