chore(ci): remove standalone:delta-stats from KNOWN_FAILURES#3561
Merged
Conversation
PR #3560 fixed the rolling-checksum signed-byte semantics (crates/checksums/src/rolling) so that oc-rsync's daemon-mode signature generation matches upstream's `schar *buf` cast in checksum.c:285. Delta matching against upstream-computed rolling checksums now produces matched > 0 in daemon mode, which is what the standalone:delta-stats interop test verifies. The previous comment ("delta engine not active in daemon code path") described the symptom (matched=0) - the actual root cause was the unsigned-vs-signed byte interpretation in the rolling checksum. If CI's interop validation surfaces a regression here, the entry can be reinstated; otherwise the dashboard counts one fewer oc-rsync gap on the path to beta criterion #3 (zero oc-rsync KNOWN_FAILURES).
oferchen
added a commit
that referenced
this pull request
May 5, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/checksums/src/rolling/so that oc-rsync now matches upstream'sschar *bufcast inchecksum.c:285.matched=0.standalone:delta-statsshould now reportmatched > 0.The previous KNOWN_FAILURES comment ("delta engine not active in daemon code path") described the symptom, not the root cause.
Test plan
tools/ci/run_interop.sh) exercisestest_delta_statswithout the KNOWN_FAILURE skip and passes.tools/ci/known_failures.conf, advancing beta criterion Add coverage for duplicate protocol offers in negotiation #3.Related: PR #3560 (rolling checksum sign-extends bytes to match upstream).