Skip to content

docs(audits): ReorderBuffer cache-behavior profiling plan at 1M files#3827

Merged
oferchen merged 1 commit into
masterfrom
docs/reorderbuffer-cache-1854
May 7, 2026
Merged

docs(audits): ReorderBuffer cache-behavior profiling plan at 1M files#3827
oferchen merged 1 commit into
masterfrom
docs/reorderbuffer-cache-1854

Conversation

@oferchen
Copy link
Copy Markdown
Owner

@oferchen oferchen commented May 7, 2026

Summary

  • Benchmark plan for cachegrind/perf profiling of BoundedReorderBuffer in crates/transfer/src/reorder_buffer.rs at 1M files.
  • Documents BTreeMap node layout (B-tree with up to 11 KV per leaf, pointer-chasing per insert/lookup), references the ring-buffer alternative explored in Improve CLI binary lookup for tests #1853, defines three delivery workloads (in-order, mostly-in-order with 5% gap, pathological reversed-window), and pins L1d/LLC miss rate plus IPC as the decision metrics.
  • Sets explicit migration criteria: ring wins only if mostly-in-order workload at window 64 hits >= 1.5x IPC or >= 2x lower L1d miss rate with end-to-end cycle ratio <= 0.7, and pathological workload does not regress beyond 10%.

Tracking task: oc-rsync #1854.

Test plan

  • Verify doc renders cleanly on GitHub.
  • Confirm the cited line ranges in crates/transfer/src/reorder_buffer.rs (struct 57-64, insert 129-146, drain 149-156) still match after any concurrent edits before merge.
  • No source-code changes; CI fmt/clippy/nextest unaffected.

Benchmark plan for cachegrind/perf profiling of BoundedReorderBuffer
(crates/transfer/src/reorder_buffer.rs) at 1M files. Documents BTreeMap
node layout, names the ring-buffer alternative from #1853, defines the
three workloads (in-order, mostly-in-order with 5% gap, pathological),
and pins L1d/LLC miss rate plus IPC as the decision metrics.

Tracking task: oc-rsync #1854.
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label May 7, 2026
@oferchen oferchen merged commit a701437 into master May 7, 2026
8 checks passed
@oferchen oferchen deleted the docs/reorderbuffer-cache-1854 branch May 8, 2026 03:48
oferchen added a commit that referenced this pull request May 18, 2026
…#3827)

Benchmark plan for cachegrind/perf profiling of BoundedReorderBuffer
(crates/transfer/src/reorder_buffer.rs) at 1M files. Documents BTreeMap
node layout, names the ring-buffer alternative from #1853, defines the
three workloads (in-order, mostly-in-order with 5% gap, pathological),
and pins L1d/LLC miss rate plus IPC as the decision metrics.

Tracking task: oc-rsync #1854.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant