feat(fast_io): add splice/vmsplice zero-copy path for network-to-disk transfers#3993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vmsplice(2)support for zero-copy userspace-buffer-to-file transfer viatry_vmsplice_to_file(), complementing the existingsplice(2)socket-to-file pathSplicePipepublic with configurable pipe buffer size (default 1MB viafcntl(F_SETPIPE_SZ)) and addsplice_to_file()/vmsplice_to_file()instance methods for pipe reuse across transferssplice_fd_to_file_via_pipe()anddrain_pipe_to_fd()helpers shared by both the free functions andSplicePipemethodsErrorKind::Unsupportedfor cross-platform compilationsplice_transferandvmsplice_transferbenches alongside theread_write_baselineCloses #1361.
Test plan
Unsupportederrors fortry_splice_to_file,try_vmsplice_to_file,SplicePipe::new())Unsupportedforrecv_fd_to_file)cargo bench -p fast_io --bench splice_piperuns on Linux and reports throughput for all three strategies