feat(fast_io): add IORING_OP_STATX batch chains for parallel directory stat (#1833)#4001
Merged
Conversation
…y stat (#1833) Add io_uring IORING_OP_STATX opcode wrapper following the existing RENAMEAT2/LINKAT pattern. Key additions: - statx_supported(): OnceLock-cached kernel probe via IORING_REGISTER_PROBE - build_statx_sqe() / build_statx_sqe_unchecked(): SQE construction - submit_statx_blocking(): single-path synchronous wrapper - submit_statx_batch(): multi-path batch submission with chunked SQ processing and automatic fallback to rustix::fs::statx on kernels < 5.11 - try_statx_batch_via_io_uring(): top-level convenience dispatch in lib.rs - Non-Linux stub in io_uring_stub.rs returning Unsupported - 18 tests covering opcode constants, probe idempotency, blocking/batch submission, error handling, order preservation, and symlink semantics
- Use iterator-based init for Vec<Option<io::Error>> (not Clone) - Pass flags as i32 directly to Statx opcode (not u32 cast) - Remove .bits() on rustix Statx fields that are plain u32
Replace field-by-field rustix_statx_to_libc conversion with a ptr::read cast. The rustix crate exposes some statx fields as newtype wrappers (StatxAttributes) or plain integers depending on backend feature configuration, causing type mismatches under --all-features. Both types are layout-identical repr(C) representations of the kernel struct statx, verified by const size/alignment assertions. Also fix .flags() i32 type mismatch in build_statx_sqe_unchecked.
libc::S_IFMT, S_IFREG, and S_IFLNK are u32 (mode_t) but statx.stx_mode is u16. Use u32::from() for type-safe widening.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…y stat (#1833) (#4001) * feat(fast_io): add IORING_OP_STATX batch chains for parallel directory stat (#1833) Add io_uring IORING_OP_STATX opcode wrapper following the existing RENAMEAT2/LINKAT pattern. Key additions: - statx_supported(): OnceLock-cached kernel probe via IORING_REGISTER_PROBE - build_statx_sqe() / build_statx_sqe_unchecked(): SQE construction - submit_statx_blocking(): single-path synchronous wrapper - submit_statx_batch(): multi-path batch submission with chunked SQ processing and automatic fallback to rustix::fs::statx on kernels < 5.11 - try_statx_batch_via_io_uring(): top-level convenience dispatch in lib.rs - Non-Linux stub in io_uring_stub.rs returning Unsupported - 18 tests covering opcode constants, probe idempotency, blocking/batch submission, error handling, order preservation, and symlink semantics * fix: correct io_uring STATX build errors on CI - Use iterator-based init for Vec<Option<io::Error>> (not Clone) - Pass flags as i32 directly to Statx opcode (not u32 cast) - Remove .bits() on rustix Statx fields that are plain u32 * fix: use byte-level statx conversion to handle rustix type differences Replace field-by-field rustix_statx_to_libc conversion with a ptr::read cast. The rustix crate exposes some statx fields as newtype wrappers (StatxAttributes) or plain integers depending on backend feature configuration, causing type mismatches under --all-features. Both types are layout-identical repr(C) representations of the kernel struct statx, verified by const size/alignment assertions. Also fix .flags() i32 type mismatch in build_statx_sqe_unchecked. * style: fix cargo fmt formatting for const assertions * fix: use &mut StatxArgs for mutable statx_buf access in SQE builders * fix: scope StatxArgs block to avoid clippy drop_non_drop lint * fix: cast stx_mode to u32 before bitwise AND with libc mode constants libc::S_IFMT, S_IFREG, and S_IFLNK are u32 (mode_t) but statx.stx_mode is u16. Use u32::from() for type-safe widening. * fix: cast remaining stx_mode to u32 in submit_statx_batch test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IORING_OP_STATX(opcode 21) wrapper infast_iofollowing the existingRENAMEAT2/LINKATpattern, withOnceLock-cached kernel probe for Linux 5.11+submit_statx_batch()for multi-path batch submission with chunked SQ processing and automatic fallback to synchronousrustix::fs::statxon older kernelsio_uring_stub.rsand top-leveltry_statx_batch_via_io_uring()convenience dispatch inlib.rsTest plan
statx_supported()returns false)io_uring::opcode::Statx::CODE