docs(audits): reorder-buffer bypass when delay-updates is off (#1886)#4015
Merged
Conversation
Audit confirms that ThresholdDeltaPipeline::new_bypass routes through ParallelDeltaPipeline::new_bypass -> DeltaConsumer::spawn_bypass -> ReorderBuffer::passthrough end-to-end, statically avoiding the spill-aware ordered path designed for task #1884. The constructor choice at the dispatcher boundary is the single decision point, and selecting it based on ServerConfig::write::delay_updates is the correct caller-side signal.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…#4015) Audit confirms that ThresholdDeltaPipeline::new_bypass routes through ParallelDeltaPipeline::new_bypass -> DeltaConsumer::spawn_bypass -> ReorderBuffer::passthrough end-to-end, statically avoiding the spill-aware ordered path designed for task #1884. The constructor choice at the dispatcher boundary is the single decision point, and selecting it based on ServerConfig::write::delay_updates is the correct caller-side signal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReorderBufferbypass added for task Ensure release checksums are verifiable #1886 is correctly wired end-to-end through the threshold dispatcher.ThresholdDeltaPipeline::new_bypass->ParallelDeltaPipeline::new_bypass->DeltaConsumer::spawn_bypass->ReorderBuffer::passthrough(no spill), and the ordered path that retains the spill-aware design from task Ensure release workflow uploads architecture-specific assets #1884.ServerConfig::write::delay_updatesas the correct signal for the constructor choice at the dispatcher boundary.ReceiverContext::set_delta_pipelineto upgrade the defaultSequentialDeltaPipeline) as a separate follow-up tracked outside this audit's scope.Context
passthrough/spawn_bypass/new_bypassconstructors across engine and transfer layers.--delay-updatesis off.new_adaptive/new_bypass_adaptiveconstructors; the same flag-driven selection rule applies once those land.Test plan
master(the audit pins all citations tocrates/engine/src/concurrent_delta/{reorder,consumer}.rsandcrates/transfer/src/{delta_pipeline,reorder_buffer,receiver/mod,config/{mod,builder}}.rs).