Skip to content

docs(audits): reorder-buffer bypass when delay-updates is off (#1886)#4015

Merged
oferchen merged 1 commit into
masterfrom
docs/reorder-bypass-delay-updates-1886
May 13, 2026
Merged

docs(audits): reorder-buffer bypass when delay-updates is off (#1886)#4015
oferchen merged 1 commit into
masterfrom
docs/reorder-bypass-delay-updates-1886

Conversation

@oferchen
Copy link
Copy Markdown
Owner

Summary

  • Audit confirming the ReorderBuffer bypass added for task Ensure release checksums are verifiable #1886 is correctly wired end-to-end through the threshold dispatcher.
  • Traces both paths: ThresholdDeltaPipeline::new_bypass -> ParallelDeltaPipeline::new_bypass -> DeltaConsumer::spawn_bypass -> ReorderBuffer::passthrough (no spill), and the ordered path that retains the spill-aware design from task Ensure release workflow uploads architecture-specific assets #1884.
  • Documents ServerConfig::write::delay_updates as the correct signal for the constructor choice at the dispatcher boundary.
  • Flags the remaining integration gap (no production caller invokes ReceiverContext::set_delta_pipeline to upgrade the default SequentialDeltaPipeline) as a separate follow-up tracked outside this audit's scope.

Context

Test plan

  • CI: fmt + clippy + nextest pass (docs-only change; no code touched).
  • Spot-check the cited file:line references against current master (the audit pins all citations to crates/engine/src/concurrent_delta/{reorder,consumer}.rs and crates/transfer/src/{delta_pipeline,reorder_buffer,receiver/mod,config/{mod,builder}}.rs).

Audit confirms that ThresholdDeltaPipeline::new_bypass routes through
ParallelDeltaPipeline::new_bypass -> DeltaConsumer::spawn_bypass ->
ReorderBuffer::passthrough end-to-end, statically avoiding the
spill-aware ordered path designed for task #1884. The constructor
choice at the dispatcher boundary is the single decision point, and
selecting it based on ServerConfig::write::delay_updates is the
correct caller-side signal.
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label May 13, 2026
@oferchen oferchen merged commit e3975ec into master May 13, 2026
8 checks passed
@oferchen oferchen deleted the docs/reorder-bypass-delay-updates-1886 branch May 14, 2026 14:57
oferchen added a commit that referenced this pull request May 18, 2026
…#4015)

Audit confirms that ThresholdDeltaPipeline::new_bypass routes through
ParallelDeltaPipeline::new_bypass -> DeltaConsumer::spawn_bypass ->
ReorderBuffer::passthrough end-to-end, statically avoiding the
spill-aware ordered path designed for task #1884. The constructor
choice at the dispatcher boundary is the single decision point, and
selecting it based on ServerConfig::write::delay_updates is the
correct caller-side signal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant