feat(progress): overflow sentinel and ir-chk prefix (D9/D10 parity)#4094
Merged
Conversation
Tighten `--progress` rendering for two upstream-parity gaps: - Verify the time-overflow sentinel renders byte-for-byte equivalent to upstream's `" ??:??:??"` after the 10-wide right-aligned field padding. Confirm progress rate has no overflow sentinel upstream and document the GB/s cap. Add boundary tests around the `9999*3600`-second clamp. - Plumb `flist_eof` through `TransferProgressEvent` and `ClientProgressUpdate` so the per-file trailer switches between `to-chk=A/B` (file list complete) and `ir-chk=A/B` (INC_RECURSE sub-lists still in flight), matching upstream's `flist_eof ? "to" : "ir"` selection. Sender plumbs the live generator state; receiver and local copy set `true` since they collect the full file list before emitting progress. Tests cover the sentinel byte form, the clamp boundary, and the chk-prefix toggle in `LiveProgress`. upstream: progress.c rprint_progress / show_progress
oferchen
force-pushed
the
feat/progress-overflow-sentinel-ir-chk-2203
branch
from
3681ec6 to
db69fa2
Compare
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…4094) * feat(progress): overflow sentinel and ir-chk prefix (D9/D10 parity) Tighten `--progress` rendering for two upstream-parity gaps: - Verify the time-overflow sentinel renders byte-for-byte equivalent to upstream's `" ??:??:??"` after the 10-wide right-aligned field padding. Confirm progress rate has no overflow sentinel upstream and document the GB/s cap. Add boundary tests around the `9999*3600`-second clamp. - Plumb `flist_eof` through `TransferProgressEvent` and `ClientProgressUpdate` so the per-file trailer switches between `to-chk=A/B` (file list complete) and `ir-chk=A/B` (INC_RECURSE sub-lists still in flight), matching upstream's `flist_eof ? "to" : "ir"` selection. Sender plumbs the live generator state; receiver and local copy set `true` since they collect the full file list before emitting progress. Tests cover the sentinel byte form, the clamp boundary, and the chk-prefix toggle in `LiveProgress`. upstream: progress.c rprint_progress / show_progress * style: apply rustfmt to progress test wrapping * fix(core): expose ClientProgressUpdate::from_transfer_event for CLI tests
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…4094) * feat(progress): overflow sentinel and ir-chk prefix (D9/D10 parity) Tighten `--progress` rendering for two upstream-parity gaps: - Verify the time-overflow sentinel renders byte-for-byte equivalent to upstream's `" ??:??:??"` after the 10-wide right-aligned field padding. Confirm progress rate has no overflow sentinel upstream and document the GB/s cap. Add boundary tests around the `9999*3600`-second clamp. - Plumb `flist_eof` through `TransferProgressEvent` and `ClientProgressUpdate` so the per-file trailer switches between `to-chk=A/B` (file list complete) and `ir-chk=A/B` (INC_RECURSE sub-lists still in flight), matching upstream's `flist_eof ? "to" : "ir"` selection. Sender plumbs the live generator state; receiver and local copy set `true` since they collect the full file list before emitting progress. Tests cover the sentinel byte form, the clamp boundary, and the chk-prefix toggle in `LiveProgress`. upstream: progress.c rprint_progress / show_progress * style: apply rustfmt to progress test wrapping * fix(core): expose ClientProgressUpdate::from_transfer_event for CLI tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close two upstream-parity gaps in
--progressrendering:??:??:??placeholder rendered byRemainingTimeEstimator::renderis byte-for-byte equivalent to upstream's" ??:??:??"after the 10-wide right-aligned field padding applied at the call sites. Confirm the rate field has no overflow sentinel upstream (progress.c:108-116only scales units up toGB/s, no placeholder), and document this in tests. Add boundary tests around the9999 * 3600-second clamp.ir-chkchk-prefix (Align --server fallback role handling #2204): plumbflist_eofthroughTransferProgressEventandClientProgressUpdateso the per-file trailer switches betweento-chk=A/Bandir-chk=A/B, matching upstream'sflist_eof ? "to" : "ir"selection (progress.c:79-82). The sender plumbs the live generator state (self.incremental.flist_eof_sent); the receiver and the local-copy forwarder settruebecause they collect the full file list before emitting progress events.Closes #2203
Closes #2204
Test plan
cargo fmt --check, clippy, nextest (Linux/macOS/Windows/musl).cli::progress::format::remaining::tests::overflow_sentinel_matches_upstream_after_paddingcli::progress::format::remaining::tests::overflow_boundary_exact_vs_off_by_onecli::progress::format::rate::tests::progress_rate_has_no_overflow_sentinelcli::progress::format::rate::tests::progress_rate_unit_tiers_mirror_upstreamcli::progress::live::tests::per_file_renders_to_chk_when_flist_completecli::progress::live::tests::per_file_renders_ir_chk_when_flist_pendingcore::client::progress::tests::flist_eof_default_true_matches_completed_listcore::client::progress::tests::flist_eof_can_be_false_for_inc_recurse