feat(transfer): wire --info=MOUNT emission (3.4.1 parity)#4116
Merged
Conversation
MOUNT sits at upstream's `INFO_GTE(MOUNT, 1)` gate but is not part of any `info_verbosity[]` level, so it only fires when explicitly enabled via `--info=MOUNT`. Upstream emits `"[%s] skipping mount-point dir %s"` from `flist.c:1319` inside `send_file_list()` once `--one-file-system` (`-xx`) prunes a directory that crosses a mount boundary. oc-rsync had the flag wired through CLI parsing but no producer. The audit doc flagged this as "Stub" with the note: "Our --one-file-system traversal does not log mount-skip events under any info gate." Wire two emission sites that cover both skip paths: 1. crates/engine/src/local_copy/executor/directory/recursive/entry.rs ::process_planned_entry - the recursive walk path. When the planner classifies a child directory as `EntryAction::SkipMountPoint`, emit the upstream-format notice via `info_log!(Mount, 1, ...)` before recording the skip event. 2. crates/engine/src/local_copy/executor/sources/orchestration.rs ::process_single_source - the root-level `-xx` path. When a source directory crosses its parent's device boundary, emit the same notice before returning early. Both sites format the message as `skipping mount-point dir <path>`; the `[sender]` role prefix is added downstream by the renderer (mirroring upstream's `who_am_i()` wrapper). The receiver-side `cannot delete mount point` notice (`generator.c:325`) is not yet mirrored because `FLAG_MOUNT_DIR` is not propagated through our flist; the audit row records this as a follow-up. Two new unit tests assert byte-for-byte upstream wording and confirm that the notice is suppressed when MOUNT is left at its default 0 level. The audit doc rolls MOUNT from Stub to Match. Closes #2162.
Merged
oferchen
added a commit
that referenced
this pull request
May 18, 2026
MOUNT sits at upstream's `INFO_GTE(MOUNT, 1)` gate but is not part of any `info_verbosity[]` level, so it only fires when explicitly enabled via `--info=MOUNT`. Upstream emits `"[%s] skipping mount-point dir %s"` from `flist.c:1319` inside `send_file_list()` once `--one-file-system` (`-xx`) prunes a directory that crosses a mount boundary. oc-rsync had the flag wired through CLI parsing but no producer. The audit doc flagged this as "Stub" with the note: "Our --one-file-system traversal does not log mount-skip events under any info gate." Wire two emission sites that cover both skip paths: 1. crates/engine/src/local_copy/executor/directory/recursive/entry.rs ::process_planned_entry - the recursive walk path. When the planner classifies a child directory as `EntryAction::SkipMountPoint`, emit the upstream-format notice via `info_log!(Mount, 1, ...)` before recording the skip event. 2. crates/engine/src/local_copy/executor/sources/orchestration.rs ::process_single_source - the root-level `-xx` path. When a source directory crosses its parent's device boundary, emit the same notice before returning early. Both sites format the message as `skipping mount-point dir <path>`; the `[sender]` role prefix is added downstream by the renderer (mirroring upstream's `who_am_i()` wrapper). The receiver-side `cannot delete mount point` notice (`generator.c:325`) is not yet mirrored because `FLAG_MOUNT_DIR` is not propagated through our flist; the audit row records this as a follow-up. Two new unit tests assert byte-for-byte upstream wording and confirm that the notice is suppressed when MOUNT is left at its default 0 level. The audit doc rolls MOUNT from Stub to Match. Closes #2162.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
MOUNT sits at upstream's `INFO_GTE(MOUNT, 1)` gate but is not part of any `info_verbosity[]` level, so it only fires when explicitly enabled via `--info=MOUNT`. Upstream emits `"[%s] skipping mount-point dir %s"` from `flist.c:1319` inside `send_file_list()` once `--one-file-system` (`-xx`) prunes a directory that crosses a mount boundary. oc-rsync had the flag wired through CLI parsing but no producer. The audit doc flagged this as "Stub" with the note: "Our --one-file-system traversal does not log mount-skip events under any info gate." Wire two emission sites that cover both skip paths: 1. crates/engine/src/local_copy/executor/directory/recursive/entry.rs ::process_planned_entry - the recursive walk path. When the planner classifies a child directory as `EntryAction::SkipMountPoint`, emit the upstream-format notice via `info_log!(Mount, 1, ...)` before recording the skip event. 2. crates/engine/src/local_copy/executor/sources/orchestration.rs ::process_single_source - the root-level `-xx` path. When a source directory crosses its parent's device boundary, emit the same notice before returning early. Both sites format the message as `skipping mount-point dir <path>`; the `[sender]` role prefix is added downstream by the renderer (mirroring upstream's `who_am_i()` wrapper). The receiver-side `cannot delete mount point` notice (`generator.c:325`) is not yet mirrored because `FLAG_MOUNT_DIR` is not propagated through our flist; the audit row records this as a follow-up. Two new unit tests assert byte-for-byte upstream wording and confirm that the notice is suppressed when MOUNT is left at its default 0 level. The audit doc rolls MOUNT from Stub to Match. Closes #2162.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2162