docs(audits): verify SSH and daemon push perf vs upstream (#2209)#4174
Merged
Conversation
Verify that PR #4154 (SSH socketpair stderr drain shutdown + russh ~/.ssh/config support) has restored SSH push and daemon push out of the pre-fix harness timeout, and that no other transfer mode regressed. Data source is benchmark workflow run 25964839057 on tag v0.6.2 at SHA c99bbbc (the PR #4154 commit itself). SSH push 1.29x slower than upstream on initial sync, daemon push 1.33x slower. Both modes recovered from the prior 120 s / 30 s harness timeouts seen in the v0.6.1 release benchmark appendix; the remaining gap to the "SSH on par" and "daemon 2x faster" targets is pre-existing and unrelated to this fix.
github-actions
Bot
added
the
documentation
oferchen
added a commit
that referenced
this pull request
May 18, 2026
) Verify that PR #4154 (SSH socketpair stderr drain shutdown + russh ~/.ssh/config support) has restored SSH push and daemon push out of the pre-fix harness timeout, and that no other transfer mode regressed. Data source is benchmark workflow run 25964839057 on tag v0.6.2 at SHA f58e6df (the PR #4154 commit itself). SSH push 1.29x slower than upstream on initial sync, daemon push 1.33x slower. Both modes recovered from the prior 120 s / 30 s harness timeouts seen in the v0.6.1 release benchmark appendix; the remaining gap to the "SSH on par" and "daemon 2x faster" targets is pre-existing and unrelated to this fix.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
) Verify that PR #4154 (SSH socketpair stderr drain shutdown + russh ~/.ssh/config support) has restored SSH push and daemon push out of the pre-fix harness timeout, and that no other transfer mode regressed. Data source is benchmark workflow run 25964839057 on tag v0.6.2 at SHA d8e0e70 (the PR #4154 commit itself). SSH push 1.29x slower than upstream on initial sync, daemon push 1.33x slower. Both modes recovered from the prior 120 s / 30 s harness timeouts seen in the v0.6.1 release benchmark appendix; the remaining gap to the "SSH on par" and "daemon 2x faster" targets is pre-existing and unrelated to this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.ssh/configsupport) restored SSH push and daemon push out of the pre-fix harness timeout.25964839057on tagv0.6.2at SHAc99bbbc6d(the PR fix(ssh): resolve goodbye-phase deadlock + load ~/.ssh/config in russh path #4154 commit itself). 50 commits between that benchmark SHA and currentmaster(080d88818); none touch the SSH wire, russh transport, daemon dispatch, or core engine transfer loop, so the post-fix numbers are representative.Test plan
docs/audits/ssh-daemon-perf-verification.md.docs:used for the commit and PR title.gh run download 25964839057).