docs(design): ReorderBuffer spill-to-tempfile for stalled successors (#1884)#4228
Merged
Merged
Conversation
…1884) Design note covering the bounded-memory reorder-buffer spill path. Documents that SpillableReorderBuffer already exists and is hardened, but is not wired into the consumer; recommends extending the reorderbuffer_memory bench with a synthetic huge-drift scenario before enabling the spill on the default path.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…1884) (#4228) Design note covering the bounded-memory reorder-buffer spill path. Documents that SpillableReorderBuffer already exists and is hardened, but is not wired into the consumer; recommends extending the reorderbuffer_memory bench with a synthetic huge-drift scenario before enabling the spill on the default path.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…1884) (#4228) Design note covering the bounded-memory reorder-buffer spill path. Documents that SpillableReorderBuffer already exists and is hardened, but is not wired into the consumer; recommends extending the reorderbuffer_memory bench with a synthetic huge-drift scenario before enabling the spill on the default path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SpillableReorderBuffer<T>(crates/engine/src/concurrent_delta/spill.rs:218) and its ENOSPC / temp-dir-vanish hardening (PR Add branding checks to CLI version banners #2247, referenced in the prompt as docs(design): daemon async runtime choice - tokio vs async-std vs threaded (#1367, #1590) #4247) already cover the spill machinery, codec, hot-zone heuristic, and RAII cleanup.consumer.rs:173-177still constructs a bareReorderBuffer, so the spill layer is dead code on the receiver's critical path;force_insertatconsumer.rs:193is the unbounded-growth fallback that a wired-in spill would retire.crates/engine/benches/reorderbuffer_memory.rs(PR bench(engine): ReorderBuffer memory occupancy at 100K/500K/1M (#1564) #4204) with an adversarial drift scenario, aDeltaResultpayload, and spill-stats reporting, gated behindBENCH_REORDER_SPILL=1.Test plan
cargo fmt --allclean