docs(design): SSH transport async I/O evaluation (#1593)#4242
Merged
Conversation
Expand the brief async-runtime-ssh-eval note into a full evaluation focused on the runtime-shape question left open by prior docs: multi-thread vs current-thread runtime ownership, AsyncFd vs tokio::process vs russh::ChannelStream bridge constructions, latency-sensitive paths inside the SSH protocol, quantified workload predictions, and a five-step sequencing plan with trigger conditions for default promotion.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Expand the brief async-runtime-ssh-eval note into a full evaluation focused on the runtime-shape question left open by prior docs: multi-thread vs current-thread runtime ownership, AsyncFd vs tokio::process vs russh::ChannelStream bridge constructions, latency-sensitive paths inside the SSH protocol, quantified workload predictions, and a five-step sequencing plan with trigger conditions for default promotion.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Expand the brief async-runtime-ssh-eval note into a full evaluation focused on the runtime-shape question left open by prior docs: multi-thread vs current-thread runtime ownership, AsyncFd vs tokio::process vs russh::ChannelStream bridge constructions, latency-sensitive paths inside the SSH protocol, quantified workload predictions, and a five-step sequencing plan with trigger conditions for default promotion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/design/async-runtime-ssh-eval.mdinto a full evaluation underdocs/design/ssh-transport-async-io-eval.mdfor issue CI: remove unsupported windows aarch64 target #1593.tokio::processstdio vsAsyncFdover raw FD vsrussh::ChannelStream), cost in RSS / scheduler footprint / blocking-vs-async learning curve, latency-sensitive read sites inside the SSH protocol (handshake greeting, multiplex headers, message dispatch), quantified workload predictions, and a five-step implementation sequencing with explicit trigger conditions for default promotion.rt-multi-threadruntime in the daemon (composes with rayon viaspawn_blocking); per-invocationcurrent_threadruntime in the CLI (negligible RSS overhead, sync engine untouched). Embedded path usesrussh::ChannelStream; subprocess path usestokio::process::Childstdio;AsyncFdraw-FD bridge retained as a documented escape hatch. Defer default promotion until five trigger conditions hold.Test plan
cargo fmt --all -- --checkpasses.async-migration-plan.md,async-ssh-transport.md,async-ssh-pipe-wrapper.md,async-ssh-evaluation.md,tokio-spawn-blocking-rayon.md) verified.async-runtime-ssh-eval.mdso the runtime-survey doc points at this evaluation.