docs(audit): FCV-3 protocol-parsing fuzz coverage gaps (#2316)#4407
Merged
Conversation
github-actions
Bot
added
the
documentation
oferchen
force-pushed
the
feature/fcv-3-coverage-gap-audit
branch
from
78b51a5 to
34e0bb2
Compare
This was referenced May 18, 2026
Merged
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…s (FCV-3 followups) Adds three fuzz targets closing the highest-priority gaps from the FCV-3 audit (PR #4407): - rsyncd_conf drives RsyncdConfig::parse, the daemon admin config parser reached on startup and reload. - auth_response drives both verify_client_response (pre-auth challenge reply verifier) and SecretsFile::parse (admin secrets file). - incremental_flist drives StreamingFileList plus IncrementalFileList finalize, exercising the post-auth pre-transfer file-list state machine under both legacy and INC_RECURSE wire modes. Each target ships with a minimal seed corpus so libFuzzer has a starting point. Daemon is wired in as a new path dep on fuzz/Cargo.toml. Also picks up trailing rustfmt cleanups in two existing fuzz targets that were flagged when running cargo fmt over the crate.
oferchen
force-pushed
the
feature/fcv-3-coverage-gap-audit
branch
from
34e0bb2 to
053954b
Compare
oferchen
force-pushed
the
feature/fcv-3-coverage-gap-audit
branch
from
053954b to
a02366e
Compare
This was referenced May 18, 2026
oferchen
added a commit
that referenced
this pull request
May 18, 2026
The vstring codec is exchanged during protocol 30+ capability negotiation, well before authentication completes, making any panic in the reader a pre-auth remote attack surface (FCV-3 audit, PR #4407). Add a libFuzzer target that drives `read_vstring` through the public `negotiate_capabilities` entry point, with a selector byte that fans out across protocol versions and role flags so both the one-byte and two-byte length encodings and the UTF-8 validation path are exercised. Register the new bin in fuzz/Cargo.toml and seed the corpus with a known-good vstring.
2 tasks
oferchen
added a commit
that referenced
this pull request
May 18, 2026
oferchen
added a commit
that referenced
this pull request
May 18, 2026
The vstring codec is exchanged during protocol 30+ capability negotiation, well before authentication completes, making any panic in the reader a pre-auth remote attack surface (FCV-3 audit, PR #4407). Add a libFuzzer target that drives `read_vstring` through the public `negotiate_capabilities` entry point, with a selector byte that fans out across protocol versions and role flags so both the one-byte and two-byte length encodings and the UTF-8 validation path are exercised. Register the new bin in fuzz/Cargo.toml and seed the corpus with a known-good vstring.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
oferchen
added a commit
that referenced
this pull request
May 18, 2026
The vstring codec is exchanged during protocol 30+ capability negotiation, well before authentication completes, making any panic in the reader a pre-auth remote attack surface (FCV-3 audit, PR #4407). Add a libFuzzer target that drives `read_vstring` through the public `negotiate_capabilities` entry point, with a selector byte that fans out across protocol versions and role flags so both the one-byte and two-byte length encodings and the UTF-8 validation path are exercised. Register the new bin in fuzz/Cargo.toml and seed the corpus with a known-good vstring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cargo fmt --allclean