Skip to content

docs(design): defer ABW-2/3/4 pending BR-3j.f bench evidence (ABW-1 audit closure)#4673

Merged
oferchen merged 1 commit into
masterfrom
docs/design-abw-2-3-4-deferred
May 21, 2026
Merged

docs(design): defer ABW-2/3/4 pending BR-3j.f bench evidence (ABW-1 audit closure)#4673
oferchen merged 1 commit into
masterfrom
docs/design-abw-2-3-4-deferred

Conversation

@oferchen
Copy link
Copy Markdown
Owner

Summary

Why defer

What unblocks the work

BR-3j.f (#2508) extends crates/engine/benches/parallel_receive_delta_perf.rs to emit verify_wall and write_wall per workload cell. The doc lifts the audit's decision gate verbatim: ratio in [0.5, 2.0] proceeds to ABW-2; outside that range closes out the line of work in project_apply_batch_write_serial.md.

Closure shape

  • ABW-2/3/4 stay open in the tracker, labelled deferred pending BR-3j.f bench evidence.
  • Per-file Mutex<FileSlot> is named as the real bottleneck; a future multi-threaded-per-file writer or a CPU-bound verify regime would re-open ABW-2. Both flagged as out-of-scope future options so contributors with bench data know which assumptions this closure rests on.

Test plan

  • cargo fmt --all (no source files changed)
  • CI required checks pass (fmt+clippy, nextest stable, Windows, macOS, Linux musl)

Discharges the ABW-1 audit's recommendation (PR #4670, section 4) to
skip the pipelined verify/write design for apply_batch_parallel until
bench evidence shows verify and write costs within 2x of each other on
a production-relevant workload cell.

- Recaps the ABW-1 quantified speedup table (1.13x balanced, 1.50x
  CPU-bound, 1.03x I/O-bound, ~0x single-file).
- Documents why deferring the design (not just the implementation) is
  the right call: peak benefit is workload-dependent, complexity-to-
  payoff is poor in the measured cells, and the PIP-3+5 dispatch
  heuristic (PR #4666) already gates the degenerate single-file case
  out of parallel-receive-delta.
- Names BR-3j.f (#2508) as the gating re-bench task and lifts the
  audit's decision gate verbatim.
- Preserves the option: per-file Mutex is the real bottleneck; a
  future multi-threaded-per-file writer or a CPU-bound verify regime
  would re-open ABW-2.
@oferchen oferchen merged commit 252b693 into master May 21, 2026
10 checks passed
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label May 21, 2026
@oferchen oferchen deleted the docs/design-abw-2-3-4-deferred branch May 22, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant