docs(design): formalize SEC-1.h mknodat deferral and document re-open triggers#4694
Merged
Conversation
… triggers SEC-1.h (PR #4683) shipped mkdirat/symlinkat/linkat sandbox helpers but explicitly punted mknodat because device/FIFO/socket creation lives behind metadata-crate abstractions that do not carry DirSandbox and is not on today's daemon-reachable TOCTOU surface. Records the rationale, sketches the helper signature, and lists the explicit re-open triggers so the SEC-1 audit chain has a clear closure for the mknodat sub-question.
github-actions
Bot
added
the
documentation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/design/sec-1-h-mknodat-deferral-2026-05-21.mdformalizing the mknodat deferral that SEC-1.h (PR feat(fast_io): mkdirat/symlinkat/linkat sandbox helpers (SEC-1.h) #4683) explicitly punted.metadatacrate lacksDirSandboxplumbing; create runs only with--devices/--specialsopt-in), sketches themknodat/mknodat_via_sandbox_or_fallbackhelper signatures, and lists explicit re-open triggers.Test plan
cargo fmt --allclean (no-op).crates/fast_io/src/dir_sandbox/at_syscalls.rsexportsmkdirat,symlinkat,linkat, and their*_via_sandbox_or_fallbackadaptors (lines 439, 482, 529, 583, 615, 655).metadata::create_device_node_with_fake_super,create_fifo_with_fake_super, andapple_fs::mknodlive incrates/metadata/src/special.rsand are reached fromcrates/engine/src/local_copy/executor/special/{device,fifo}.rs.metadatacrate has noDirSandboximport or carrier today.daemondoes not directly mediate device-node creation; module gating remains the only daemon-side control.