docs(engine): pick ENOSPC injection mechanism for spill tests (SPL-33.a)#4770
Merged
Merged
Conversation
Evaluate five candidate ENOSPC injection mechanisms (tmpfs size-cap, fallocate filler, mock writer, failpoints crate, fuse-mt) against CI compatibility on the Linux musl / macOS / Windows tiles and against the SPL-32 audit's site inventory. Recommend a userspace mock writer for the unit-test layer plus a Linux-gated fallocate filler for one real-kernel integration test, and pin the chosen mechanism's API surface in pseudo-code so SPL-33.b has a concrete target. Cross-references docs/design/spill-fs-error-audit.md (SPL-32) for the syscall site inventory and the SpillError::PriorSpillsLost wiring landed via SPL-35/36/37 (#4749).
cb6baa3 to
ae43e39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
size=N,fallocatefiller, mock writer,failpointscrate,fuse-mt) against CI compatibility on the Linux musl / macOS / Windows tiles and against the SPL-32 audit's syscall-site inventory.FaultingFile+FaultPlanunder#[cfg(test)]) for the SPL-33.b unit-test layer, paired with a single Linux-gatedfallocatefiller integration test for real-kernel coverage. Pins the chosen mechanism's API surface in pseudo-code so SPL-33.b has a concrete implementation target.docs/design/spill-fs-error-audit.md(SPL-32, 23 syscall sites: 9 recoverable / 17 bubble-up / 3 silent) and theSpillError::PriorSpillsLostwiring shipped via SPL-35/36/37 (feat(engine): SpillError::PriorSpillsLost typed variant + consumer wiring (SPL-35..37) #4749).Test plan
git diff --statshows one new markdown file underdocs/design/.FaultPlanAPI surface and the seven-row test matrix unchanged.