Enable environment-driven system rsync delegation in oc-rsyncd#971
Merged
Conversation
6 tasks
oferchen
added a commit
that referenced
this pull request
May 1, 2026
Adds scripts/benchmark_flist_memory.sh which compares peak RSS of oc-rsync against upstream rsync 3.4.1 at 100K and 1M directory scales under three flist modes: - Mode A: full flist (--no-inc-recursive) - Mode B: default (receiver INC_RECURSE) - Mode C: sender INC_RECURSE (skipped, pending #1862 opt-in flag) Measures wall-clock time and peak RSS via /usr/bin/time -v, runs each mode 3 times and takes the median, writes TSV to target/benchmarks/ and emits an optional markdown summary. Fixtures live under /tmp/oc-rsync-bench (not bind-mounted) with a path guard that refuses to rm anywhere outside that prefix. Documents 2026-05-01 baseline numbers in docs/benchmarks/flist-memory-baseline-2026-05-01.md - upstream peak RSS drops from 76.8 MB (Mode A) to 7.5 MB (Mode B) at 1M files, while oc-rsync stays at ~218 MB across both modes (sender-side INC_RECURSE not yet active). Refs #966/#971 for the RSS gap context.
oferchen
added a commit
that referenced
this pull request
May 5, 2026
Adds scripts/benchmark_flist_memory.sh which compares peak RSS of oc-rsync against upstream rsync 3.4.1 at 100K and 1M directory scales under three flist modes: - Mode A: full flist (--no-inc-recursive) - Mode B: default (receiver INC_RECURSE) - Mode C: sender INC_RECURSE (skipped, pending #1862 opt-in flag) Measures wall-clock time and peak RSS via /usr/bin/time -v, runs each mode 3 times and takes the median, writes TSV to target/benchmarks/ and emits an optional markdown summary. Fixtures live under /tmp/oc-rsync-bench (not bind-mounted) with a path guard that refuses to rm anywhere outside that prefix. Documents 2026-05-01 baseline numbers in docs/benchmarks/flist-memory-baseline-2026-05-01.md - upstream peak RSS drops from 76.8 MB (Mode A) to 7.5 MB (Mode B) at 1M files, while oc-rsync stays at ~218 MB across both modes (sender-side INC_RECURSE not yet active). Refs #966/#971 for the RSS gap context.
This was referenced May 7, 2026
oferchen
added a commit
that referenced
this pull request
May 7, 2026
Plan re-baselines peak RSS for full vs incremental flist on 100K and 1M directory pushes after #1862 landed sender INC_RECURSE. Captures the state machine in crates/transfer/src/generator/file_list/inc_recurse.rs plus the receiver-side path in receiver/file_list.rs, and ties the bench gate to the v0.6.1 push regression revert (#3744) so default-flip needs both wall-clock and RSS evidence. Refs #1864, #1862, #966, #971, #972, #2088.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Plan re-baselines peak RSS for full vs incremental flist on 100K and 1M directory pushes after #1862 landed sender INC_RECURSE. Captures the state machine in crates/transfer/src/generator/file_list/inc_recurse.rs plus the receiver-side path in receiver/file_list.rs, and ties the bench gate to the v0.6.1 push regression revert (#3744) so default-flip needs both wall-clock and RSS evidence. Refs #1864, #1862, #966, #971, #972, #2088.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68fa6e06406c8323a0c0a502fc9ecb4a