fix: add meaningful alt text to primary navbar logo for SEO#114
Merged
Conversation
The dark logo image had alt="" which caused SEO tools to flag it as missing alt text. Per WCAG images-of-text guidance, logo wordmarks use the brand name as alt text. The light logo retains alt="" + aria-hidden="true" (decorative) since the dark logo carries the accessible description for the pair. The link's aria-label is kept so the accessible name is present in light mode when the dark logo is display:none. Signed-off-by: Sinduri Guntupalli <sinduri.guntupalli@dynatrace.com>
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dark logo image had alt="" which caused SEO tools to flag it as missing alt text. Per WCAG images-of-text guidance, logo wordmarks use the brand name as alt text.
The light logo retains alt="" + aria-hidden="true" (decorative) since the dark logo carries the accessible description for the pair. The link's aria-label is kept so the accessible name is present in light mode when the dark logo is display:none.
Type of change
featnew featurefixbug fixrefactorno behavior changedocs/chore/config/perf/style/securityManual checks